Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data should be redacted in docker_secret #31366

Merged
merged 1 commit into from
Oct 5, 2017
Merged

data should be redacted in docker_secret #31366

merged 1 commit into from
Oct 5, 2017

Conversation

gundalow
Copy link
Contributor

@gundalow gundalow commented Oct 5, 2017

SUMMARY

As reported by ntwrkguru

ISSUE TYPE
  • Bugfix Pull Request

@gundalow
Copy link
Contributor Author

gundalow commented Oct 5, 2017

docker_secret was added in 2.4, so adding as 2.4.1 candidate

@ansibot
Copy link
Contributor

ansibot commented Oct 5, 2017

cc @chouseknecht
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 5, 2017
@samdoran samdoran added this to TODO: Blocker in 2.4.x Blocker List Oct 5, 2017
@samdoran samdoran merged commit e859d0d into ansible:devel Oct 5, 2017
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Oct 5, 2017
@samdoran samdoran moved this from TODO: Blocker to In Progress in 2.4.x Blocker List Oct 5, 2017
samdoran pushed a commit that referenced this pull request Oct 5, 2017
@gundalow @samdoran
data should be redacted in docker_secret (#31366)
bd460ee 
(cherry picked from commit e859d0d)
@samdoran
Copy link
Contributor

samdoran commented Oct 5, 2017

Cherry-picked for inclusion in 2.4.1

@samdoran samdoran moved this from In Progress to Done in 2.4.x Blocker List Oct 5, 2017
@pyup-bot pyup-bot mentioned this pull request Jan 1, 2018
Closed
This was referenced Jan 31, 2018
Closed
Closed
Closed
Closed
Closed
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chouseknecht chouseknecht Awaiting requested review from chouseknecht

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.1
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gundalow @ansibot @samdoran