Fix rollback in junos_config #31424
Merged
Fix rollback in junos_config #31424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ansible#30778 * Call `load_configuration` with rollback id in case the id is given as input * Pass rollback id to `get_diff()` to fetch diff from device
ansibot
added
affects_2.5
s-hertel
removed
the
needs_triage
ansibot
added
needs_revision
ansibot
added
core_review
Qalthos
approved these changes
Oct 10, 2017
| @@ -101,9 +105,14 @@ def test_junos_config_confirm(self): | |||
| self.assertEqual(kwargs['confirm_timeout'], 40) | |||
|
|
|||
| def test_junos_config_rollback(self): | |||
| set_module_args(dict(rollback=10)) | |||
| rollback = 10 | |||
There was a problem hiding this comment.
Not sure why you pulled this out
There was a problem hiding this comment.
rollback value passed as input to the module is used in assert below to check right value is passed to function.
There was a problem hiding this comment.
...right. Well I feel silly now
ganeshrn
added a commit
to ganeshrn/ansible
that referenced
this pull request
Oct 11, 2017
* Fix rollback in junos_config Fixes ansible#30778 * Call `load_configuration` with rollback id in case the id is given as input * Pass rollback id to `get_diff()` to fetch diff from device * Fix unit test (cherry picked from commit 88da95b)
BondAnthony
pushed a commit
to BondAnthony/ansible
that referenced
this pull request
Oct 14, 2017
* Fix rollback in junos_config Fixes ansible#30778 * Call `load_configuration` with rollback id in case the id is given as input * Pass rollback id to `get_diff()` to fetch diff from device * Fix unit test
mtb-xt
pushed a commit
to mtb-xt/ansible
that referenced
this pull request
Oct 15, 2017
* Fix rollback in junos_config Fixes ansible#30778 * Call `load_configuration` with rollback id in case the id is given as input * Pass rollback id to `get_diff()` to fetch diff from device * Fix unit test
This was referenced Jan 31, 2018
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #30778
load_configurationwith rollback id in casethe id is given as input
get_diff()to fetch diff from deviceISSUE TYPE
COMPONENT NAME
junos_config
ANSIBLE VERSION
ADDITIONAL INFORMATION