Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ping docs to refer to win_ping #31444

Merged
merged 1 commit into from
Oct 8, 2017
Merged

Change ping docs to refer to win_ping #31444

merged 1 commit into from
Oct 8, 2017

Conversation

abadger
Copy link
Contributor

@abadger abadger commented Oct 7, 2017

SUMMARY

Ping module docs told windows users to use the ping module instead. Should be telling windows users to use the win_ping module instead.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

lib/ansible/modules/system/ping.py

ANSIBLE VERSION
devel, 2.4

@abadger
Copy link
Contributor Author

abadger commented Oct 7, 2017

@nitzmahone

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. docs_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 7, 2017
@jhawkesworth
Copy link
Contributor

Let's have this.

I will merge, please backport

@jhawkesworth jhawkesworth merged commit 4804e99 into ansible:devel Oct 8, 2017
@abadger abadger deleted the ping-win_ping branch October 8, 2017 15:18
abadger added a commit that referenced this pull request Oct 8, 2017
@abadger
Change ping docs to refer to win_ping (#31444)
991d996 
(cherry picked from commit 4804e99)
@abadger
Copy link
Contributor Author

abadger commented Oct 8, 2017

cherry-picked to stable-2.4 for the 2.4.1rc1 release.

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Oct 9, 2017
BondAnthony pushed a commit to BondAnthony/ansible that referenced this pull request Oct 14, 2017
@abadger @BondAnthony
Change ping docs to refer to win_ping (ansible#31444)
1a02959
@pyup-bot pyup-bot mentioned this pull request Jan 1, 2018
Closed
This was referenced Jan 31, 2018
Closed
Closed
Closed
Closed
Closed
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@dagwieers dagwieers added the windows Windows community label Feb 11, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abadger @jhawkesworth @dagwieers @bcoca @ansibot