win_copy: Add missing check_mode fix #31469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.5
dagwieers
changed the title
dagwieers
suggested changes
Oct 9, 2017
| @@ -76,7 +76,9 @@ Function Copy-File($source, $dest) { | |||
| } | |||
|
|
|||
| if (Test-Path -Path $dest -PathType Leaf) { | |||
| Remove-Item -Path $dest -Force -Recurse | Out-Null | |||
| if (-not $check_mode) { | |||
| Remove-Item -Path $dest -Force -Recurse | Out-Null | |||
There was a problem hiding this comment.
I would simply do:
Remove-Item -Path $dest -Force -Recurse -WhatIf:$check_mode | Out-NullThere was a problem hiding this comment.
yup, got miscarried by earlier comments that avoided WhatIf because the path didn't exist; which is not the case here as the if conditional is Test-Path.... (facepalm)
There was a problem hiding this comment.
No worries. In reality there won't be a real difference, on the other hand if Microsoft at some point improves Remove-Item to also detect other failure-cases (in a safe way) the -WhatIf implementation may prove to be more useful.
ansibot
added
needs_revision
|
If Shippable likes it, I will merge this. Thanks ! |
dagwieers
approved these changes
Oct 9, 2017
jborean93
pushed a commit
that referenced
this pull request
Oct 9, 2017
* Add missing check_mode fix * Refactor conditional to use the one embedded in Remove-Item (cherry picked from commit 5bf9f27)
|
Thanks for the fix @vtsingaras, I have cherry-picked this commit to stable-2.4 https://github.com/ansible/ansible/commits/stable-2.4 for the 2.4.1 release. |
BondAnthony
pushed a commit
to BondAnthony/ansible
that referenced
this pull request
Oct 14, 2017
* Add missing check_mode fix * Refactor conditional to use the one embedded in Remove-Item
This was referenced Jan 31, 2018
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
win_copy would remove the destination file if it existed even when running with check_mode: yes
ISSUE TYPE
COMPONENT NAME
win_copy
ANSIBLE VERSION
2.4.0