Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix paths to actually be config file relative #31533

Merged
merged 3 commits into from
Oct 11, 2017

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Oct 10, 2017

SUMMARY

also allow to unfrack paths for 'not cwd'

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

config/paths

ANSIBLE VERSION
2.4/2.5

@bcoca bcoca added this to In Progress in 2.4.x Blocker List Oct 10, 2017
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. utils/path needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 10, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Oct 10, 2017
also allow to unfrack paths for 'not cwd'
only use -i 'localhost,' for adhoc in pull
@abadger
Copy link
Contributor

abadger commented Oct 10, 2017

Checking for transient errors.. This run, failed on OSX in two separate waysi n the become integration test:

{
    "changed": false, 
    "failed": true, 
    "module_stderr": "Traceback (most recent call last):\n  File \"/tmp/ansible_9_AciQ/ansible_module_user.py\", line 2286, in \n    main()\n  File \"/tmp/ansible_9_AciQ/ansible_module_user.py\", line 2243, in main\n    info = user.user_info()\n  File \"/tmp/ansible_9_AciQ/ansible_module_user.py\", line 621, in user_info\n    info = self.get_pwd_info()\n  File \"/tmp/ansible_9_AciQ/ansible_module_user.py\", line 616, in get_pwd_info\n    return list(pwd.getpwnam(self.name))\nKeyError: 'getpwnam(): name not found: ansibletest1'\n", 
    "module_stdout": "", 
    "msg": "MODULE FAILURE", 
    "rc": 0
}

and then

{
"changed": false, 
"err": " DS Error: -14988 (eNotYetImplemented)\n", 
"failed": true, 
"msg": "Unable to get the next available uid", 
"out": "list: DS error: eNotYetImplemented\n", 
"rc": 140
}

centos6 failure I think is due to the new tests for rpm_key. Trying to address that here: #31548

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 11, 2017
@abadger abadger merged commit 3886f80 into ansible:devel Oct 11, 2017
abadger pushed a commit that referenced this pull request Oct 11, 2017
* fix paths to actually be config file relative

also allow to unfrack paths for 'not cwd'
only use -i 'localhost,' for adhoc in pull
(cherry picked from commit 3886f80)
@abadger abadger moved this from In Progress to Done in 2.4.x Blocker List Oct 11, 2017
@abadger
Copy link
Contributor

abadger commented Oct 11, 2017

Cherrypicked and merged for 2.4.1rc1

BondAnthony pushed a commit to BondAnthony/ansible that referenced this pull request Oct 14, 2017
* fix paths to actually be config file relative

also allow to unfrack paths for 'not cwd'
only use -i 'localhost,' for adhoc in pull
mtb-xt pushed a commit to mtb-xt/ansible that referenced this pull request Oct 15, 2017
* fix paths to actually be config file relative

also allow to unfrack paths for 'not cwd'
only use -i 'localhost,' for adhoc in pull
@bcoca bcoca added this to Done in ansible config Nov 20, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@bcoca bcoca deleted the fix_config_pathing branch January 18, 2019 21:00
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cli/pull support:core This issue/PR relates to code supported by the Ansible Engineering Team. utils/path
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants