Correct usage for shutil.rmtree #31541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready_for_review |
ansibot
added
affects_2.5
|
I think a unit test should be introduced that exercise those lines (like the example I gave in #31225). |
Akasurde
force-pushed
the
i31225
branch
2 times, most recently
from
15933d8
to
d243568
Compare
|
The test |
ansibot
added
ci_verified
Fix adds correct usage of shutil.rmtree in git module Fixes: ansible#31225 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ansibot
added
core_review
|
ready_for_review |
mkrizek
removed
the
needs_triage
ansibot
added
shipit
- use multi-line YAML
- remove unneeded {{ }} around vars in conditionals
- remove unneeded quotes
- add task file name to task names for easier troubleshooting when things fail
ansibot
added
core_review
ansibot
added
needs_revision
The older versions of Jinja2 in RHEL/CentOS 6 required assertion tasks using the map filter to be skipped. The older version of git required gzip compression to be skipped on RHEL/CentOS 6.
|
CI failure in integration test 'ansible_distribution_major_version' is undefined This error occurs on FreeBSD and macOS. |
mattclay
added
the
ci_verified
ansibot
added
core_review
BondAnthony
pushed a commit
to BondAnthony/ansible
that referenced
this pull request
Oct 14, 2017
* Correct usage for shutil.rmtree Fix adds correct usage of shutil.rmtree in git module Fixes: ansible#31225 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> * Include archive tests so they get run * Use new include syntax * Cleanup syntax on git tests - use multi-line YAML - remove unneeded {{ }} around vars in conditionals - remove unneeded quotes - add task file name to task names for easier troubleshooting when things fail * Make archive tests work for RHEL/CentOS 6 The older versions of Jinja2 in RHEL/CentOS 6 required assertion tasks using the map filter to be skipped. The older version of git required gzip compression to be skipped on RHEL/CentOS 6. * Account for ansible_distribution_major_version missing
mtb-xt
pushed a commit
to mtb-xt/ansible
that referenced
this pull request
Oct 15, 2017
* Correct usage for shutil.rmtree Fix adds correct usage of shutil.rmtree in git module Fixes: ansible#31225 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> * Include archive tests so they get run * Use new include syntax * Cleanup syntax on git tests - use multi-line YAML - remove unneeded {{ }} around vars in conditionals - remove unneeded quotes - add task file name to task names for easier troubleshooting when things fail * Make archive tests work for RHEL/CentOS 6 The older versions of Jinja2 in RHEL/CentOS 6 required assertion tasks using the map filter to be skipped. The older version of git required gzip compression to be skipped on RHEL/CentOS 6. * Account for ansible_distribution_major_version missing
abadger
moved this from TODO: Nice to have
to To be cherrypicked (rc only)
in 2.4.x Blocker List
|
cherrypicked to stable-2.4 for 2.4.1rc2 |
abadger
moved this from To be cherrypicked (rc only)
to Done in 2.4.1
in 2.4.x Blocker List
abadger
pushed a commit
that referenced
this pull request
Oct 18, 2017
* Correct usage for shutil.rmtree Fix adds correct usage of shutil.rmtree in git module Fixes: #31225 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> * Include archive tests so they get run * Use new include syntax * Cleanup syntax on git tests - use multi-line YAML - remove unneeded {{ }} around vars in conditionals - remove unneeded quotes - add task file name to task names for easier troubleshooting when things fail * Make archive tests work for RHEL/CentOS 6 The older versions of Jinja2 in RHEL/CentOS 6 required assertion tasks using the map filter to be skipped. The older version of git required gzip compression to be skipped on RHEL/CentOS 6. * Account for ansible_distribution_major_version missing (cherry picked from commit a047fe0)
This was referenced Jan 31, 2018
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix adds correct usage of shutil.rmtree in git module
Fixes: #31225
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/source_control/git.py
ANSIBLE VERSION