Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nxos_igmp_snooping #31688

Merged
merged 1 commit into from
Oct 23, 2017
Merged

fix nxos_igmp_snooping #31688

merged 1 commit into from
Oct 23, 2017

Conversation

trishnaguha
Copy link
Member

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

fixes #30439

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/nxos/nxos_igmp_snooping

ANSIBLE VERSION
2.5.0, 2.4.0

@ansibot
Copy link
Contributor

ansibot commented Oct 13, 2017

cc @GGabriele @jedelman8 @mikewiebe @privateip @rahushen @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Oct 13, 2017
@ansibot
Copy link
Contributor

ansibot commented Oct 13, 2017

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/modules/network/nxos/nxos_igmp_snooping.py:181:12: undefined-variable Undefined variable 'existine'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. owner_pr This PR is made by the module's maintainer. labels Oct 13, 2017
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. owner_pr This PR is made by the module's maintainer. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 13, 2017
@trishnaguha trishnaguha added affects_2.4 This issue/PR affects Ansible v2.4 and removed needs_triage Needs a first human triage before being processed. labels Oct 13, 2017
@trishnaguha trishnaguha changed the title fix nxos_igmp_snooping [WIP]fix nxos_igmp_snooping Oct 13, 2017
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. and removed owner_pr This PR is made by the module's maintainer. labels Oct 13, 2017
@trishnaguha
fix nxos_igmp_snooping
028c8b1 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha changed the title [WIP]fix nxos_igmp_snooping fix nxos_igmp_snooping Oct 16, 2017
@trishnaguha trishnaguha removed the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Oct 16, 2017
@ansibot ansibot added the owner_pr This PR is made by the module's maintainer. label Oct 16, 2017
@trishnaguha trishnaguha mentioned this pull request Oct 16, 2017
Closed
@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2017

cc @kedarX
click here for bot help

@gundalow gundalow added this to the 2.5.0 milestone Oct 18, 2017
@trishnaguha trishnaguha merged commit 529b7a7 into ansible:devel Oct 23, 2017
@trishnaguha trishnaguha deleted the nxos_igmp_snooping_fix branch October 23, 2017 04:10
trishnaguha added a commit to trishnaguha/ansible that referenced this pull request Oct 23, 2017
@trishnaguha
fix nxos_igmp_snooping (ansible#31688)
b7267a1 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 529b7a7)
abadger pushed a commit that referenced this pull request Oct 26, 2017
@trishnaguha @abadger
fix nxos_igmp_snooping (#31688)
6d4d2d8 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 529b7a7)
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added nxos Cisco NXOS community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

nxos_igmp_snooping is not idempotent for non-default values on D1 image on N7K.
4 participants
@trishnaguha @ansibot @dagwieers @gundalow