Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ansible_distribution_major_version to macOS #31708

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Add ansible_distribution_major_version to macOS #31708

merged 1 commit into from
Oct 24, 2017

Conversation

samdoran
Copy link
Contributor

SUMMARY

Add ansible_distribution_major_version to macOS facts.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

module_utils/facts/system/distribution.py

ANSIBLE VERSION
2.5

@samdoran
Copy link
Contributor Author

samdoran commented Oct 13, 2017 •
edited

@alikins Do we have unit tests for facts? I didn't see any that checked specific output.

@samdoran samdoran added this to TODO: Next release in 2.4.x Blocker List Oct 13, 2017
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 feature_pull_request module_utils/facts needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 13, 2017
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Oct 13, 2017
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 13, 2017
@alikins
Copy link
Contributor

alikins commented Oct 24, 2017

LGTM

@alikins alikins merged commit 4dce9dc into ansible:devel Oct 24, 2017
@abadger
Copy link
Contributor

abadger commented Oct 26, 2017

Cherrypicked for 2.4.2beta1

@abadger abadger moved this from TODO: Next release to Done in 2.4.2 in 2.4.x Blocker List Oct 26, 2017
abadger pushed a commit that referenced this pull request Oct 26, 2017
@samdoran @abadger
Add ansible_distribution_major_version to macOS (#31708)
872b409 
(cherry picked from commit 4dce9dc)
abadger pushed a commit that referenced this pull request Oct 26, 2017
@samdoran @abadger
Add ansible_distribution_major_version to macOS (#31708)
2f30de3 
(cherry picked from commit 4dce9dc)
@samdoran samdoran deleted the macos-facts branch October 26, 2017 22:33
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 feature This issue/PR relates to a feature request. module_utils/facts support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samdoran @alikins @abadger @ansibot