Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove hosts from removed when rescuing #31710

Merged
merged 1 commit into from
Oct 16, 2017
Merged

remove hosts from removed when rescuing #31710

merged 1 commit into from
Oct 16, 2017

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Oct 13, 2017 •
edited

SUMMARY

hosts were being removed from play vars even when rescued
fixes #31707

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iterator

ANSIBLE VERSION
2.4/2.5

@s-hertel
Copy link
Contributor

Fixes #31707

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request executor/play_iterator needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 13, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Oct 13, 2017
@bcoca bcoca added this to In Progress in 2.4.x Blocker List Oct 13, 2017
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 13, 2017
@bcoca bcoca removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 16, 2017
@bcoca bcoca merged commit 618627f into ansible:devel Oct 16, 2017
@bcoca bcoca deleted the really_rescue branch October 16, 2017 19:14
@bcoca bcoca moved this from In Progress to TODO: Next release in 2.4.x Blocker List Oct 16, 2017
@abadger
Copy link
Contributor

abadger commented Oct 17, 2017

Merged to temp-staging-post-2.4.1 branch for the 2.4.2 release.

@abadger abadger moved this from TODO: Next release to Done in 2.4.2 in 2.4.x Blocker List Oct 17, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. executor/play_iterator support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hosts disappears from play host even when rescued in a block
4 participants
@bcoca @s-hertel @abadger @ansibot