Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable use of empty manageiq arguments #31774

Merged
merged 2 commits into from
Oct 23, 2017
Merged

Enable use of empty manageiq arguments #31774

merged 2 commits into from
Oct 23, 2017

Conversation

yaacov
Copy link
Contributor

@yaacov yaacov commented Oct 16, 2017 •
edited

SUMMARY

Currently we can not omit the managiq arguments:

Bug: If example.yaml does not have the manageiq_connection argument, we will get "missing required arguments: manageiq_connection" error:

Example

Without this fix we can not use the system variables:

MIQ_URL=http://127.0.0.1:3000 MIQ_USERNAME=admin MIQ_PASSWORD=smartvm ansible-playbook example.yaml

will give:

"msg": "missing required arguments: manageiq_connection"

With this bug fix, the above line will work.

This change is adding:

manageiq module_utils, responsible for management of ManageIQ

All the modules, including docs, tests and usage examples can be found here

Currently, the only requirement for the modules is manageiq-api-client-python

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

manageiq.py (module_utils)

ANSIBLE VERSION

ansible 2.5.0.0

@yaacov
Copy link
Contributor Author

yaacov commented Oct 16, 2017

@cben @zgalor @joelddiaz please review

@yaacov yaacov changed the title anable use of empty manageiq arguments Enable use of empty manageiq arguments Oct 16, 2017
@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2017

cc @abellotti @dkorn @gtanzillo
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. module_utils/ needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 16, 2017
zgalor
zgalor approved these changes Oct 16, 2017
View reviewed changes
Copy link

@zgalor zgalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@yaacov
Copy link
Contributor Author

yaacov commented Oct 16, 2017

shipit

1 similar comment
@zgalor
Copy link

zgalor commented Oct 16, 2017

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Oct 16, 2017
@cben
Copy link
Contributor

cben commented Oct 16, 2017

shipit

yaacov
yaacov commented Oct 17, 2017
View reviewed changes
lib/ansible/module_utils/manageiq.py Outdated
@@ -46,6 +46,12 @@ def manageiq_argument_spec():
ca_bundle_path=dict(required=False, default=None),
)

return dict(
manageiq_connection=dict(type='dict',
default=dict(verify_ssl=False),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default verify_ssl should be True

@yaacov
Copy link
Contributor Author

yaacov commented Oct 17, 2017

shipit

just made the default verify_ssl arg true instead of false ...

@cben @zgalor @joelddiaz please re-shipit 🙏

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed shipit This PR is ready to be merged by Core labels Oct 17, 2017
@zgalor
Copy link

zgalor commented Oct 17, 2017

you can take your code and shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 17, 2017
@cben
Copy link
Contributor

cben commented Oct 17, 2017

shipit

@joelddiaz
Copy link
Contributor

works as advertised in my environment 👍

@yaacov
Copy link
Contributor Author

yaacov commented Oct 18, 2017

bot_status

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2017

waiting_on: ansible
module: manageiq_provider
supported_by: community
maintainers: abellotti cben dkorn gtanzillo yaacov zgalor
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 3
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): yaacov zgalor cben
shipit_actors_other: []

click here for bot help

@resmo
Copy link
Contributor

resmo commented Oct 23, 2017

shipit

@resmo resmo merged commit 2765ee4 into ansible:devel Oct 23, 2017
@yaacov yaacov mentioned this pull request Oct 23, 2017
Closed
yaacov added a commit to yaacov/ansible that referenced this pull request Nov 6, 2017
@yaacov
use new manageiq_connection parameter config from commit ansible#31774
c077fa5
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@cben cben mentioned this pull request Apr 18, 2018
Closed
@sivel sivel mentioned this pull request Apr 18, 2018
Merged
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cben cben cben approved these changes

@zgalor zgalor zgalor approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. module_utils/ module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yaacov @ansibot @zgalor @cben @joelddiaz @resmo