Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_regedit: fix extra info coming into stdout #31813

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

jborean93
Copy link
Contributor

@jborean93 jborean93 commented Oct 16, 2017

SUMMARY

New-Item and Remove-Item output into which eventually ends up in the stdout stream sent back to Ansible. Usually this isn't an issue as Ansible parses the output from when it first detects { but in the case of the property of data containg that character (like a guid of json string), Ansible won't be able to parse the output and it fails even though it really didn't

This change makes sure that extra data is not sent to the output/stdout stream so Ansible won't get confused in the end.

fixes #31423
fixes #31782

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_regedit

ANSIBLE VERSION
2.4
2.5

@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2017

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Oct 16, 2017
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 16, 2017
@jborean93 jborean93 added this to Nominated in 2.4.x Blocker List Oct 16, 2017
@jborean93 jborean93 moved this from Nominated to TODO: Nice to have in 2.4.x Blocker List Oct 16, 2017
@jborean93 jborean93 merged commit 888de84 into ansible:devel Oct 17, 2017
@virtuald
Copy link
Contributor

Ha, that totally makes sense. Thanks for tracking it down, I'll try it out later this week hopefully.

@jborean93 jborean93 deleted the win_regedit-output-fix branch October 17, 2017 03:41
@abadger abadger moved this from TODO: Nice to have to To be cherrypicked (rc only) in 2.4.x Blocker List Oct 17, 2017
abadger pushed a commit that referenced this pull request Oct 18, 2017
@abadger
Copy link
Contributor

abadger commented Oct 18, 2017

cherry-picked for 2.4.1rc2

@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
No open projects
2.4.x Blocker List
Done in 2.4.1
Development

Successfully merging this pull request may close these issues.

win_regedit: Module output messed up win_regedit failure when creating new values
4 participants