-Fixes JSON parsing(use JSON object instead of string) for facts module #31818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kedarkekan
added
affects_2.4
ansibot
added
core_review
ganeshrn
reviewed
Oct 17, 2017
| from ansible.module_utils.basic import AnsibleModule | ||
| from ansible.module_utils.junos import junos_argument_spec, check_args, get_param | ||
| from ansible.module_utils.junos import get_configuration | ||
| from ansible.module_utils.pycompat24 import get_exception | ||
| from ansible.module_utils.netconf import send_request | ||
| from ansible.module_utils.six import iteritems | ||
| from ansible.module_utils._text import to_text |
There was a problem hiding this comment.
Is to_text used anywhere in this module?
ganeshrn
reviewed
Oct 17, 2017
| @@ -155,7 +158,7 @@ def populate(self): | |||
| config = self.get_text(reply, 'configuration-text') | |||
|
|
|||
| elif config_format == 'json': | |||
| config = str(reply.text).strip() | |||
| config = json.loads(reply.text) | |||
There was a problem hiding this comment.
Also, I think this can be updated to use module.from_json()
ganeshrn
reviewed
Oct 17, 2017
|
cherry-picked for 2.4.2beta1 |
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes output parsing for junos facts to use JSON object instead of a string
Fixes #31489
ISSUE TYPE
COMPONENT NAME
modules/network/junos
ANSIBLE VERSION