Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: fix archive when update is set to no #31829

Merged
merged 1 commit into from
Oct 31, 2017
Merged

git: fix archive when update is set to no #31829

merged 1 commit into from
Oct 31, 2017

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Oct 17, 2017

SUMMARY

Fixes #30774

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

git

ANSIBLE VERSION
devel
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 17, 2017
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Oct 18, 2017
@mkrizek mkrizek added this to READY TO REVIEW in CEM Oct 18, 2017
@jctanner
Copy link
Contributor

@robinro are you still available to do git reviews?

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 28, 2017
@robinro
Copy link
Contributor

robinro commented Oct 31, 2017

@jctanner In general not.

Since I already had a look:
@mkrizek Thanks for the PR.
It looks good to me (didn't run it, though). Since I'm pretty sure someone will complain about not being able to archive some branch they didn't pull before, you might want to add some comment to the docs regarding update like Operations like archive will work on the existing (old) repository and might not respond to changes to the options version or remote.

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 31, 2017
@mkrizek mkrizek merged commit e3a847a into ansible:devel Oct 31, 2017
@mkrizek mkrizek mentioned this pull request Oct 31, 2017
Closed
@mkrizek mkrizek deleted the git-update-fix branch October 31, 2017 13:01
@mkrizek mkrizek moved this from READY TO REVIEW to DONE in CEM Oct 31, 2017
@mkrizek mkrizek mentioned this pull request Nov 1, 2017
Merged
mkrizek added a commit that referenced this pull request Nov 6, 2017
@mkrizek
git: fix archive when update is set to no (#31829)
d8bfed6 
(cherry picked from commit e3a847a)
@mkrizek mkrizek added this to Done in 2.4.2 in 2.4.x Blocker List Nov 6, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.2
CEM
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git archive is not working if update is set to no
5 participants
@mkrizek @jctanner @robinro @gundalow @ansibot