Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix include_role unit tests #31920

Merged
merged 2 commits into from Nov 2, 2017
Merged

Fix include_role unit tests #31920

merged 2 commits into from Nov 2, 2017
+31 −10

Conversation

pilou-
Copy link
Contributor

@pilou- pilou- commented Oct 19, 2017

SUMMARY

Fix include_role unit tests. Since e609618:

  • include_role can not be static anymore
  • include_role unit tests don't test anything because get_tasks_vars never yield.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

include_role

ANSIBLE VERSION
ansible 2.5.0 (devel b9223cdc89) last updated 2017/10/18 16:39:11 (GMT +200)

@pilou-
Ensure include_role unit tests check something
f3bf8a4 
This is not the case: get_tasks_vars doesn't yield
@pilou-
Fix include_role unit tests
acfcbd0 
Since e609618, include_role are not
static anymore.
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Oct 19, 2017
@pilou-
Copy link
Contributor Author

pilou- commented Oct 19, 2017

cc @jimi-c

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 19, 2017
@pilou- pilou- mentioned this pull request Oct 20, 2017
Closed
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 27, 2017
@pilou- pilou- mentioned this pull request Nov 1, 2017
Closed
@gundalow gundalow requested a review from jimi-c November 2, 2017 15:12
@jimi-c jimi-c merged commit 43914b3 into ansible:devel Nov 2, 2017
abadger pushed a commit that referenced this pull request Nov 2, 2017
@pilou- @abadger
Fix include_role unit tests (#31920)
35d942d 
* Ensure include_role unit tests check something

This is not the case: get_tasks_vars doesn't yield

* Fix include_role unit tests

Since e609618, include_role are not
static anymore.

(cherry picked from commit 43914b3)
@abadger
Copy link
Contributor

abadger commented Nov 2, 2017

cherrypicked for 2.4.2beta3

kiorky pushed a commit to corpusops/ansible that referenced this pull request Nov 6, 2017
@pilou- @kiorky
Fix include_role unit tests (ansible#31920)
79a1d8e 
* Ensure include_role unit tests check something

This is not the case: get_tasks_vars doesn't yield

* Fix include_role unit tests

Since e609618, include_role are not
static anymore.

(cherry picked from commit 43914b3)
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jimi-c jimi-c jimi-c approved these changes

Assignees

@jimi-c jimi-c

Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pilou- @abadger @jimi-c @ansibot @jborean93