Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firewalld: don't reference undefined variable in error case #31949

Merged
merged 2 commits into from
Oct 19, 2017
Merged

firewalld: don't reference undefined variable in error case #31949

merged 2 commits into from
Oct 19, 2017

Conversation

maxamillion
Copy link
Contributor

Signed-off-by: Adam Miller maxamillion@fedoraproject.org

SUMMARY

Fixes #31927

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

firewalld

ANSIBLE VERSION
ansible 2.4.0.0              
  config file = /etc/ansible/ansible.cfg                   
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']           
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible                                            
  executable location = /usr/bin/ansible                   
  python version = 2.7.14 (default, Sep 17 2017, 18:50:44) [GCC 7.2.0]

@maxamillion
firewalld: don't reference undefined variable in error case
9280fcc 
Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 19, 2017
@maxamillion
firewalld: don't set exception as var and not use it
e865f21 
Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>
@abadger
Copy link
Contributor

abadger commented Oct 19, 2017

rebuild_merge

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Oct 19, 2017
@abadger abadger added this to To be cherrypicked (rc only) in 2.4.x Blocker List Oct 19, 2017
@ansibot ansibot merged commit 5b7d161 into ansible:devel Oct 19, 2017
@abadger
Copy link
Contributor

abadger commented Oct 26, 2017

Cherry-picked for 2.4.2beta1

@abadger abadger moved this from To be cherrypicked (rc only) to Done in 2.4.2 in 2.4.x Blocker List Oct 26, 2017
abadger pushed a commit that referenced this pull request Oct 26, 2017
@maxamillion @abadger
firewalld: don't reference undefined variable in error case (#31949)
d57a032 
* firewalld: don't reference undefined variable in error case

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>

* firewalld: don't set exception as var and not use it

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>
(cherry picked from commit 5b7d161)
abadger pushed a commit that referenced this pull request Oct 26, 2017
@maxamillion @abadger
firewalld: don't reference undefined variable in error case (#31949)
e7d8685 
* firewalld: don't reference undefined variable in error case

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>

* firewalld: don't set exception as var and not use it

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>
(cherry picked from commit 5b7d161)
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

firewalld: clarify failure reason when not installed
3 participants
@maxamillion @abadger @ansibot