junos scp module

[GIC-de]

SUMMARY

The junos_scp module transfers files via SCP from or to remote devices running Junos.

Example Usage:

  - name: upload file to device
    junos_scp:
        src: /tmp/test.text
        provider: "{{ provider }}"

ISSUE TYPE

• New Module Pull Request

COMPONENT NAME

• lib/ansible/modules/network/junos/junos_scp.py

ANSIBLE VERSION

ansible 2.3.2.0

[ansibot]

cc @Qalthos @ganeshrn
click here for bot help

[ansibot]

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/network/junos/junos_scp.py:0:0: E306 version_added is not a valid version number: '2.X'
lib/ansible/modules/network/junos/junos_scp.py:0:0: E312 No RETURN provided

click here for bot help

[ansibot]

@Qalthos

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

[gundalow]

@GIC-de As of Ansible 2.4 all Network modules require tests, Can you please add a unit and integration test for this. Thanks in advance.

[ansibot]

The test ansible-test sanity --test import --python 2.6 [?] failed with the following error:

lib/ansible/modules/network/junos/junos_scp.py:89:0: ImportError: No module named junos

The test ansible-test sanity --test import --python 2.7 [?] failed with the following error:

lib/ansible/modules/network/junos/junos_scp.py:89:0: ImportError: No module named junos

The test ansible-test sanity --test import --python 3.5 [?] failed with the following error:

lib/ansible/modules/network/junos/junos_scp.py:89:0: ImportError: No module named 'ansible.module_utils.junos'

The test ansible-test sanity --test import --python 3.6 [?] failed with the following error:

lib/ansible/modules/network/junos/junos_scp.py:89:0: ModuleNotFoundError: No module named 'ansible.module_utils.junos'

The test ansible-test sanity --test import --python 3.7 [?] failed with the following error:

lib/ansible/modules/network/junos/junos_scp.py:89:0: ModuleNotFoundError: No module named 'ansible.module_utils.junos'

click here for bot help

[ansibot]

The test ansible-test sanity --test import --python 2.6 [?] failed with the following error:

lib/ansible/modules/network/junos/junos_scp.py:89:0: ImportError: No module named junos

The test ansible-test sanity --test import --python 2.7 [?] failed with the following error:

lib/ansible/modules/network/junos/junos_scp.py:89:0: ImportError: No module named junos

The test ansible-test sanity --test import --python 3.5 [?] failed with the following error:

lib/ansible/modules/network/junos/junos_scp.py:89:0: ImportError: No module named 'ansible.module_utils.junos'

The test ansible-test sanity --test import --python 3.6 [?] failed with the following error:

lib/ansible/modules/network/junos/junos_scp.py:89:0: ModuleNotFoundError: No module named 'ansible.module_utils.junos'

The test ansible-test sanity --test import --python 3.7 [?] failed with the following error:

lib/ansible/modules/network/junos/junos_scp.py:89:0: ModuleNotFoundError: No module named 'ansible.module_utils.junos'

click here for bot help

[GIC-de]

I need help with the failed sanity check. Locally the test was working but it failed in your environment. The error is confusing because this part of the code (import ansible.mudle_utils.junos...) is 100% equal to the existing modules like junos_package.

[gundalow]

Our CI (Shippable) rebase PRs before running tests. I believe you are seeing this as in the devel branch'module_utils has been reorganized.

I believe you need to rebase this PR. After that you will nerd something like module_utils.networking.{platform}

[gundalow]

http://docs.ansible.com/ansible/latest/dev_guide/developing_rebasing.html

[ganeshrn]

@GIC-de After rebase you need to update import statement as ansible.module_utils.network.junos.junos
Reference: https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/junos/junos_command.py#L175

[ansibot]

@GIC-de this PR contains the following merge commits:

• 20ca2e3

Please rebase your branch to remove these commits.

click here for bot help

[gundalow]

rebuild_merge