Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure] Add check mode for acs deletion #32063

Merged
merged 1 commit into from
Nov 1, 2017
Merged

[Azure] Add check mode for acs deletion #32063

merged 1 commit into from
Nov 1, 2017

Conversation

yaweiw
Copy link
Contributor

@yaweiw yaweiw commented Oct 24, 2017 •
edited by gundalow
Loading

SUMMARY

Add check mode when deleting ACS instance
Issue reference: #32062

ISSUE TYPE
  • Bugfix Pull Request

Description updated by Gundalow

@yaweiw yaweiw changed the title Add check mode for acs deletion [Azure] Add check mode for acs deletion Oct 24, 2017
@ansibot
Copy link
Contributor

ansibot commented Oct 24, 2017

@yaweiw Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 24, 2017

cc @julienstroheker
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 azure cloud module This issue/PR relates to a module. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 24, 2017
@yaweiw
Copy link
Contributor Author

yaweiw commented Oct 24, 2017

SUMMARY

Add check mode when deleting ACS instance

ISSUE TYPE
  • Bugfix Pull Request

@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Oct 25, 2017
@ansibot ansibot added bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. and removed needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. labels Oct 25, 2017
@abadger abadger added this to TODO: Nice to have in 2.4.x Blocker List Oct 26, 2017
@thaumos
Copy link
Contributor

thaumos commented Oct 26, 2017

cc @tstringer @haroldwongms @jborean93 @nitzmahone

@haroldwongms
Copy link
Contributor

This change looks good. Nice catch.

@haroldwongms
Copy link
Contributor

shipit

1 similar comment
@xscript
Copy link
Contributor

xscript commented Nov 1, 2017

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 1, 2017
@ansibot ansibot merged commit d7c8fdb into ansible:devel Nov 1, 2017
@yaweiw yaweiw deleted the acsbugfix branch November 1, 2017 06:20
abadger pushed a commit that referenced this pull request Nov 1, 2017
@yaweiw @abadger
add check mode for acs delete (#32063)
0faa72e 
(cherry picked from commit d7c8fdb)
@abadger
Copy link
Contributor

abadger commented Nov 1, 2017

cherrypicked for 2.4.2beta2

@abadger abadger moved this from Nice to have to Done in 2.4.2 in 2.4.x Blocker List Nov 1, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 automerge This PR was automatically merged by ansibot. azure bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yaweiw @ansibot @thaumos @haroldwongms @xscript @abadger @gundalow