Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eos_eapi: adding the desired state config to the new vrf fixes #32111 #32112

Merged
merged 3 commits into from
Nov 1, 2017
Merged

eos_eapi: adding the desired state config to the new vrf fixes #32111 #32112

merged 3 commits into from
Nov 1, 2017

Conversation

dathelen
Copy link
Contributor

@dathelen dathelen commented Oct 25, 2017 •
edited by trishnaguha
Loading

SUMMARY

fixes #32111
Adding the final shut/no shut to the newly minted eapi operational vrf. eapi can only run in one vrf at at time, so we need add the state commands to the new vrf even if they are present for the default running config

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

eos_eapi

ANSIBLE VERSION
ansible 2.4.0.0
  config file = None
  configured module search path = [u'/Users/dt/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.11 (default, Nov 13 2016, 20:35:45) [GCC 4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.31)]

@ansibot
Copy link
Contributor

ansibot commented Oct 25, 2017

cc @privateip @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. support:network This issue/PR relates to code supported by the Ansible Network Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 25, 2017
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 25, 2017
@ansibot ansibot added the test This PR relates to tests. label Oct 25, 2017
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Oct 25, 2017
@gundalow gundalow changed the title adding the desired state config to the new vrf fixes #32111 eos_eapi: adding the desired state config to the new vrf fixes #32111 Oct 25, 2017
@gundalow
Copy link
Contributor

Adding to 2.4.x project as I believe this fix should be backported to 2.4

@gundalow gundalow added this to the 2.5.0 milestone Oct 25, 2017
@bcoca bcoca added this to Nominated in 2.4.x Blocker List Oct 25, 2017
@abadger abadger moved this from Nominated to TODO: Nice to have in 2.4.x Blocker List Oct 26, 2017
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Oct 26, 2017
ganeshrn
ganeshrn approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ganeshrn ganeshrn merged commit 2c99cbc into ansible:devel Nov 1, 2017
ganeshrn pushed a commit to ganeshrn/ansible that referenced this pull request Nov 1, 2017
@dathelen @ganeshrn
eos_eapi: adding the desired state config to the new vrf fixes ansibl…
af131a8 
…e#32111 (ansible#32112)

* adding the desired state config to the new vrf fixes ansible#32111

* fix default vrf initial configured

* add unit test

* Update CHANGELOG

(cherry picked from commit 2c99cbc)
@ganeshrn ganeshrn mentioned this pull request Nov 1, 2017
Merged
ganeshrn pushed a commit to ganeshrn/ansible that referenced this pull request Nov 1, 2017
@dathelen @ganeshrn
eos_eapi: adding the desired state config to the new vrf fixes ansibl…
6e05af1 
…e#32111 (ansible#32112)

* adding the desired state config to the new vrf fixes ansible#32111

* fix default vrf initial configured

* add unit test

* Update CHANGELOG

(cherry picked from commit 2c99cbc)
@ganeshrn
Copy link
Member

ganeshrn commented Nov 1, 2017

@dathelen Thank you.

ganeshrn added a commit that referenced this pull request Nov 1, 2017
@ganeshrn
eos_eapi: adding the desired state config to the new vrf fixes #32111 (…
bc01b5d 
…#32112) (#32452)

* adding the desired state config to the new vrf fixes #32111

* fix default vrf initial configured

* add unit test

* Update CHANGELOG

(cherry picked from commit 2c99cbc)
@abadger
Copy link
Contributor

abadger commented Nov 1, 2017

This was cherry-picked for 2.4.2beta2

@abadger abadger moved this from Nice to have to Done in 2.4.2 in 2.4.x Blocker List Nov 1, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.2
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

eos_eapi doesn't enable non-default vrfs if the default vrf is already configured
5 participants
@dathelen @ansibot @gundalow @ganeshrn @abadger