Avoid default inventory proccessing for pull #32135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now pull's own special inventory processing should work correctly - also removed ineffective set_defaults fixes ansible#31449
ansibot
added
affects_2.5
agaffney
reviewed
Oct 25, 2017
lib/ansible/cli/__init__.py
Outdated
| # process inventory options | ||
| if hasattr(self.options, 'inventory'): | ||
| # process inventory options except for CLIs that require their own processing | ||
| if hasattr(self.options, 'inventory') and self.__class__.__name__ not in ('PullCLI'): |
There was a problem hiding this comment.
Should this be a flag set within the class rather than a check for a hard-coded class name?
ansibot
added
the
needs_revision
bcoca
removed
the
needs_triage
(cherry picked from commit aad5d1432583c4aa4105b774f38c80498e85de59)
|
Merged for 2.4.2beta1 |
abadger
pushed a commit
that referenced
this pull request
Oct 26, 2017
* Avoid default inventory proccessing for pull - now pull's own special inventory processing should work correctly - also removed ineffective set_defaults fixes #31449 * use class property instead * only do localhost for adhoc (cherry picked from commit aad5d1432583c4aa4105b774f38c80498e85de59) (cherry picked from commit ca71a50)
abadger
pushed a commit
that referenced
this pull request
Oct 26, 2017
* Avoid default inventory proccessing for pull - now pull's own special inventory processing should work correctly - also removed ineffective set_defaults fixes #31449 * use class property instead * only do localhost for adhoc (cherry picked from commit aad5d1432583c4aa4105b774f38c80498e85de59) (cherry picked from commit ca71a50)
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fixes #31449
ISSUE TYPE
COMPONENT NAME
pull
ANSIBLE VERSION