Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TLS1.1 and TLS1.2 for win_package #32184

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Enable TLS1.1 and TLS1.2 for win_package #32184

merged 1 commit into from
Oct 27, 2017

Conversation

benschweizer
Copy link
Contributor

SUMMARY

This is the same as #26833 for win_get_url.ps1

"By default, .NET4.5 supports TLS1.1 and TLS1.2 but they are disabled. When systems administrators disable less secure protocols, requests will fail as HTTPS negotiation will fail when the server only supports newer protocols but the client has the support disabled. This change tries to enable them, but will continue gracefully if they are not available.

Powershell is not something I'd consider one of my strengths. I'd be happy to refactor with guidance if necessary, but the code does work as is."

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module win_package

ANSIBLE VERSION
ansible 2.4.0.0
  config file = /home/bsc@dst-its.de/.ansible.cfg
  configured module search path = [u'/home/bsc@dst-its.de/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /opt/ansible/2.4.0.0/lib/python2.7/site-packages/ansible
  executable location = /opt/ansible/2.4.0.0/bin/ansible
  python version = 2.7.13 (default, Jan 19 2017, 14:48:08) [GCC 6.3.0 20170118]
ADDITIONAL INFORMATION

n/a

@ansibot
Copy link
Contributor

ansibot commented Oct 26, 2017

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Oct 26, 2017
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Oct 26, 2017
@jborean93
Copy link
Contributor

Sigh, why Microsoft just doesn't auto negotiate the highest crypto it can get I have no idea. Thanks for the PR

@jborean93 jborean93 merged commit f2023a8 into ansible:devel Oct 27, 2017
jborean93 pushed a commit that referenced this pull request Oct 27, 2017
@jborean93
Copy link
Contributor

Cherry-picked to stable-2.4 1e318f6. Will be available on the 2.4.2 release.

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants