Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow health_check_port to be a string #32228

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Allow health_check_port to be a string #32228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/ansible/modules/cloud/amazon/elb_target_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
health_check_port:
description:
- The port the load balancer uses when performing health checks on targets.
Can be set to 'traffic-port' to match target port.
required: false
default: "The port on which each target receives traffic from the load balancer."
health_check_path:
Expand Down Expand Up @@ -360,7 +361,7 @@ def create_or_update_target_group(connection, module):
params['HealthCheckProtocol'] = module.params.get("health_check_protocol").upper()

if module.params.get("health_check_port") is not None:
params['HealthCheckPort'] = str(module.params.get("health_check_port"))
params['HealthCheckPort'] = module.params.get("health_check_port")

if module.params.get("health_check_interval") is not None:
params['HealthCheckIntervalSeconds'] = module.params.get("health_check_interval")
Expand Down Expand Up @@ -622,7 +623,7 @@ def main():
dict(
deregistration_delay_timeout=dict(type='int'),
health_check_protocol=dict(choices=['http', 'https', 'tcp', 'HTTP', 'HTTPS', 'TCP'], type='str'),
health_check_port=dict(type='int'),
health_check_port=dict(),
health_check_path=dict(default=None, type='str'),
health_check_interval=dict(type='int'),
health_check_timeout=dict(type='int'),
Expand Down