Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Fix ios_logging module issue where facility is being deleted along with… #32234

Merged
merged 1 commit into from
Oct 27, 2017
Merged

- Fix ios_logging module issue where facility is being deleted along with… #32234

merged 1 commit into from
Oct 27, 2017

Conversation

kedarkekan
Copy link
Contributor

  • Fix ios_logging module issue where facility is being deleted along with host
  • Remove default facility, as facility is not standard on remote syslog server
SUMMARY

Fixes: #32225

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_logging

ANSIBLE VERSION
2.5.0

@kedarkekan
- Fix logging module issue where facility is being deleted along with…
d8cb593 
… host

- Remove default facility, as facility is not standard on remote syslog server
@ansibot
Copy link
Contributor

ansibot commented Oct 27, 2017

cc @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Oct 27, 2017
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Oct 27, 2017
rcarrillocruz
rcarrillocruz approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@rcarrillocruz rcarrillocruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kedarkekan kedarkekan merged commit 7d5dcce into ansible:devel Oct 27, 2017
@kedarkekan kedarkekan added the affects_2.4 This issue/PR affects Ansible v2.4 label Oct 27, 2017
@kedarkekan kedarkekan deleted the fix32225 branch October 27, 2017 10:01
@kedarkekan kedarkekan added this to TODO: Nice to have in 2.4.x Blocker List Oct 27, 2017
@kedarkekan kedarkekan restored the fix32225 branch October 27, 2017 10:11
kedarkekan added a commit that referenced this pull request Oct 27, 2017
@kedarkekan
Revert "- Fix logging module issue where facility is being deleted al…
a9e1be7 
…ong with host (#32234)"

This reverts commit 7d5dcce.
@abadger
Copy link
Contributor

abadger commented Nov 1, 2017

cherrypicked to stable-2.4 for 2.4.2beta2

abadger pushed a commit that referenced this pull request Nov 1, 2017
@kedarkekan @abadger
- Fix logging module issue where facility is being deleted along with…
ac1c7b0 
… host (#32234)

- Remove default facility, as facility is not standard on remote syslog server
(cherry picked from commit 7d5dcce)
@abadger abadger moved this from Nice to have to Done in 2.4.2 in 2.4.x Blocker List Nov 1, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Feb 27, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcarrillocruz rcarrillocruz rcarrillocruz approved these changes

@trishnaguha trishnaguha Awaiting requested review from trishnaguha

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ios_logging overzealously removes config
6 participants
@kedarkekan @ansibot @abadger @rcarrillocruz @dagwieers @mkrizek