Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure we always have a basedir #32269

Merged
merged 1 commit into from
Oct 30, 2017
Merged

ensure we always have a basedir #32269

merged 1 commit into from
Oct 30, 2017
+5 −4

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Oct 27, 2017 •
edited

SUMMARY

Restores correct behaviour when referencing hostvars from hostvars would not have a basedir set.
fixes #31755
fixes #31758

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

hostvars

ANSIBLE VERSION
2.4/2.5
ADDITIONAL INFORMATION

@bcoca bcoca added this to TODO: Blocker in 2.4.x Blocker List Oct 27, 2017
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 27, 2017
This was referenced Oct 27, 2017
Closed
Closed
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Oct 27, 2017
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 27, 2017
@bcoca bcoca removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 27, 2017
@bcoca bcoca merged commit 64220fc into ansible:devel Oct 30, 2017
@bcoca bcoca deleted the always_basedir branch October 30, 2017 16:28
@bcoca
Copy link
Member Author

bcoca commented Oct 30, 2017

cp'd for 2.4.2 release

@bcoca bcoca moved this from TODO: Blocker to Done in 2.4.2 in 2.4.x Blocker List Oct 30, 2017
@bcoca bcoca mentioned this pull request Nov 2, 2017
Closed
@fullyint fullyint mentioned this pull request Nov 6, 2017
Merged
@hvindin hvindin mentioned this pull request Nov 12, 2017
Closed
@valentinocossar valentinocossar mentioned this pull request Jan 4, 2018
Closed
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hostvars files of hosts outside current play is not loaded Group variables missing from hostvars
2 participants
@bcoca @ansibot