Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move asa provider to suboptions #32356

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Move asa provider to suboptions #32356

merged 1 commit into from
Nov 1, 2017
+7 −9

Conversation

ganeshrn
Copy link
Member

@ganeshrn ganeshrn commented Oct 30, 2017 •
edited
Loading

SUMMARY

Fixes #32343

  • Move provider arg spec as part of suboptions
    to validate input args against provider spec.
  • This handles no_log for password arg correctly.

Merged to devel PR #28984
( cherry picked from commit 599fe23 )

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aos_*

ANSIBLE VERSION
2.4
ADDITIONAL INFORMATION

@ganeshrn ganeshrn requested a review from Qalthos October 30, 2017 16:29
@ansibot
Copy link
Contributor

ansibot commented Oct 30, 2017

cc @ogenstad
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bugfix_pull_request module_utils/ needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 30, 2017
@ansible ansible deleted a comment from ansibot Oct 31, 2017
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 31, 2017
@ganeshrn ganeshrn removed the needs_triage Needs a first human triage before being processed. label Oct 31, 2017
@ganeshrn
Move asa provider to suboptions
e10e2f0 
Fixes ansible#32343

* Move provider arg spec as part of suboptions
  to validate input args against provider spec.
* This handles `no_log` for password arg correctly.

Merged to devel PR ansible#28984

( cherry picked from commit 599fe23 )
@ganeshrn
Copy link
Member Author

Fix will be available in 2.4.2beta2 release

@ganeshrn ganeshrn merged commit 8c1dfdb into ansible:stable-2.4 Nov 1, 2017
@ganeshrn ganeshrn deleted the asa_password_issue branch November 1, 2017 03:46
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added asa Cisco ASA community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Awaiting requested review from Qalthos

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 asa Cisco ASA community backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies module_utils/ networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ganeshrn @ansibot @dagwieers