win_service: quoted path fix

[jborean93]

SUMMARY

In 2.4, the powershell type of path has an explicit check as to whether it is a valid path or not. The win_service module used this for the path check but it is a valid scenario to quote this value which fails in 2.4. This change removes the path type for path but it will still expand the environment variables like before. Includes an integration test to ensure it doesn't regress again in the future.

Fixes #32368

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

win_service

ANSIBLE VERSION

2.4

[ansibot]

cc @chrishoffman @dagwieers @jhawkesworth
click here for bot help

[jhawkesworth]

Code looks good to me, but wondering whether we should have a different name instead of 'path' as it seems to mean 'path to command including arguments'. Perhaps just alias 'path' as 'command_line'?

Probably not worth doing unless it is a distinction and a convention we want to adopt across modules.

Having a type for paths is nice as that's something you can check for correctness - command lines aren't really something we would ever be able to validate though.

[jborean93]

From @dssdss at #32368 (comment)

Now, it works! Thank you very much.

[jborean93]

@jhawkesworth we can add an alias, as the path type was just added so we can expand environment variables in line. It was later extended to validate paths. At the time I added the path option to win_service I didn't think of the fact it should take in arguments and just used a common option name. I'm not opposed to adding in the alias but it should probably be in another PR and discussed in a wider group.