Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-ascii errors in config manager #32511

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Fix non-ascii errors in config manager #32511

merged 1 commit into from
Nov 2, 2017

Conversation

abadger
Copy link
Contributor

@abadger abadger commented Nov 2, 2017

SUMMARY

When using display methods, we want to use text strings.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

inventory/manager.py

ANSIBLE VERSION
devel 2.4

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request inventory Inventory category needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 2, 2017
@abadger abadger added this to Nice to have in 2.4.x Blocker List Nov 2, 2017
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Nov 2, 2017
@abadger
Copy link
Contributor Author

abadger commented Nov 2, 2017

Failure is a transient test issue talking to a keyserver. Merging.

@abadger abadger merged commit d166bba into ansible:devel Nov 2, 2017
@abadger abadger deleted the inv-manager-unicode branch November 2, 2017 18:05
@abadger
Copy link
Contributor Author

abadger commented Nov 3, 2017

cherrypicked to stable-2.4 for the 2.4.2beta3 release.

@abadger abadger moved this from Nice to have to Done in 2.4.2 in 2.4.x Blocker List Nov 3, 2017
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Nov 3, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. inventory Inventory category needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abadger @ansibot @s-hertel