handle ignore_errors in loop

[bcoca]

SUMMARY

most worked by accident, not using the correct task values
fixes #32384

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

core

ANSIBLE VERSION

2.4/2.5

[guenhter]

- hosts: 127.0.0.1
  gather_facts: false
  vars:
    ignore_assertion_errors: false
  tasks:
    - name: With variable
      assert:
        that: item < 2
        msg: "{{item}} isn't < 2"
      ignore_errors: ignore_assertion_errors
      with_items:
        - 1
        - 2

Results in the error:

ERROR! The task includes an option with an undefined variable. The error was: 'item' is undefined

The error appears to have been in '/private/tmp/playbook.yml': line 6, column 7, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

  tasks:
    - name: With variable
      ^ here

On branch devel it runs through (falsely but it doesn't crashes)

[bcoca]

@guenhter sorry, try again now, i ended up finding a deeper error and ran through several iterations, but at this point it should be correct for all cases.

[guenhter]

@bcoca I checked and there is one thing left I don't completely understand (and maybe isn't even a bug).

In the playbook above:

When I use:

      ignore_errors: "{{ignore_assertion_errors}}"

This works perfectly fine. BUT

      ignore_errors: ignore_assertion_errors

seems always evaluate to false

I wasn't sure if this is expected so I checked with changed_when:

      changed_when: ignore_assertion_errors

This does exactly what I expect: when the variable is true, it show a change in the recap, if the variable is false it doesn't.

So the good news is, that your fix is working with the {{ variable }} expression, but just variable doesn't work.

[bcoca]

when: clauses have an 'implied' {{ }} so they do not need it, every other keyword requires the {{}} to process variables.

[guenhter]

Ok, thanks for the clarification. Than this seems fine.

[nelsg]

For information:
I'm faced the same issue when I upgraded from Ansible 2.2.1 to 2.3.2.
After some tests, this regression was introduced with Ansible 2.3.0.
Then caution if you planed to upgrade to a version higher than 2.2.3, choose at least version 2.4.2.

Maybe this fix must be integrated with future version 2.3.3, no ?