Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling for user login #32613

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Nov 7, 2017

SUMMARY

This fix adds additional error handling for vmware connect
method, where username provided user does not have required
permissions to use/login ESXi.

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/vmware.py

ANSIBLE VERSION
2.5devel

This fix adds additional error handling for vmware connect
method, where username provided user does not have required
permissions to use/login ESXi.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Nov 7, 2017

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request module_utils/vmware needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Nov 7, 2017
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Nov 8, 2017
@jborean93 jborean93 merged commit 8096738 into ansible:devel Nov 8, 2017
@jborean93
Copy link
Contributor

Hey @Akasurde is this something you would want to be cherry-picked to stable-2.4?

@Akasurde
Copy link
Member Author

@jborean93 Yes, we can. Less priority.

@Akasurde Akasurde deleted the vmware_guest_error branch November 10, 2017 06:05
jborean93 pushed a commit that referenced this pull request Nov 10, 2017
This fix adds additional error handling for vmware connect
method, where username provided user does not have required
permissions to use/login ESXi.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 8096738)
@jborean93
Copy link
Contributor

Cherry-picked to stable-2.4 64f75fc, will be in the 2.4.2rc1 release.

@Akasurde
Copy link
Member Author

@jborean93 Thanks.

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cloud module_utils/vmware support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants