Remove the params option from jenkns_plugin and yum_repository #32708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.5
jborean93
removed
the
needs_triage
samdoran
reviewed
Nov 8, 2017
| @@ -391,6 +385,8 @@ | |||
| - The repo file will be automatically deleted if it contains no repository. | |||
| - When removing a repository, beware that the metadata cache may still remain | |||
| on disk until you run C(yum clean all). Use a notification handler for this. | |||
| - "The C(params) parameter was removed in Ansible-2.5 due to circumventing Ansible's parameter | |||
There was a problem hiding this comment.
Maybe just say 'Ansible 2.5' rather than having the dash.
It was decided that these options which override Ansible module options from a generic, unchecked dict are an antipattern for Ansible Modules and must be removed: https://meetbot.fedoraproject.org/ansible-meeting/2017-09-28/ansible_dev_meeting.2017-09-28-15.00.log.html Fixes ansible#30874
abadger
force-pushed
the
remove-params
branch
from
e8a1f62
to
3934540
Compare
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was decided that these options which override Ansible module options
from a generic, unchecked dict are an antipattern for Ansible Modules
and must be removed:
https://meetbot.fedoraproject.org/ansible-meeting/2017-09-28/ansible_dev_meeting.2017-09-28-15.00.log.html
Fixes #30874
ISSUE TYPE
COMPONENT NAME
ANSIBLE VERSION