Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed psobject to hashtables that were missed #32710

Merged
merged 2 commits into from
Nov 15, 2017
Merged

removed psobject to hashtables that were missed #32710

merged 2 commits into from
Nov 15, 2017

Conversation

jborean93
Copy link
Contributor

SUMMARY

A change in 2.4 meant that we can no longer pass PSObjects to Fail-Json or Exit-Json or else it fails. Unfortunately some modules were missed and this change fixes up those modules as well as remove some other references to PSObjects where they are not needed.

While having tests would have picked this up, I don't have the bandwidth right now to continue writing them for now.

Fixes: #32696

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

windows

ANSIBLE VERSION
2.5

@jborean93 jborean93 mentioned this pull request Nov 9, 2017
Closed
@ansibot
Copy link
Contributor

ansibot commented Nov 9, 2017

cc @cchurch @dagwieers @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. windows Windows community needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 9, 2017
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Nov 9, 2017
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 10, 2017
@nitzmahone nitzmahone merged commit 5e20fd0 into ansible:devel Nov 15, 2017
@jborean93 jborean93 deleted the win-psobject-fix branch November 15, 2017 22:55
jborean93 added a commit that referenced this pull request Nov 15, 2017
@jborean93
removed psobject to hashtables that were missed (#32710)
b059dfe 
* removed psobject to hashtables that were missed

* fix up win_region change

(cherry picked from commit 5e20fd0)
@jborean93
Copy link
Contributor Author

Cherry-picked to stable 2.4 b059dfe, will be released with 2.4.2rc1

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible.ModuleUtils.Legacy Fail-Json is failing when being used with IIS based windows modules
4 participants
@jborean93 @ansibot @nitzmahone @samdoran