Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undeprecated with_ #32805

Merged
merged 2 commits into from
Nov 14, 2017
Merged

undeprecated with_ #32805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76cfdec
undeprecated with_
bcoca Nov 10, 2017
3c7273d
pepe
bcoca Nov 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,13 @@ Ansible Changes By Release

### Major Changes
* Removed the previously deprecated 'accelerate' mode and all associated keywords and code.
* New simpler and more intuitive 'loop' keyword for task loops
* New simpler and more intuitive 'loop' keyword for task loops. The ``with_<lookup>`` loops will be deprecated in the near future and eventually removed.
* Added fact namespacing, from now on facts will be available under `ansible_facts` namespace (i.e. `ansible_facts.os_distribution`) w/o the `ansilbe_` prefix.
They will continue to be added into the main namespace directly, but now with a configuration toggle to enable this,
currently on by default, in the future it will be off.

### Deprecations
* Previously deprecated 'hostfile' config settings have been 're-deprecated' as previously code did not warn about deprecated configuration settings.
* The ``with_<lookup>`` loops are deprecated in favor of the new ``loop`` keyword

### Minor Changes
* added a few new magic vars corresponding to configuration/command line options:
Expand Down
3 changes: 2 additions & 1 deletion lib/ansible/playbook/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ def _preprocess_with_loop(self, ds, new_ds, k, v):
raise AnsibleError("you must specify a value when using %s" % k, obj=ds)
new_ds['loop_with'] = loop_name
new_ds['loop'] = v
display.deprecated("with_ type loops are being phased out, use the 'loop' keyword instead", version="2.9")
# FIXME: reenable afte 2.5
# display.deprecated("with_ type loops are being phased out, use the 'loop' keyword instead", version="2.10")

def preprocess_data(self, ds):
'''
Expand Down