Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nmap inventory #32857

Merged
merged 3 commits into from Mar 29, 2018
Merged

Nmap inventory #32857

merged 3 commits into from Mar 29, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Nov 13, 2017

SUMMARY

Use nmap to generate inventory

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/inventory/nmap

ANSIBLE VERSION
2.5

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 feature_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 13, 2017
@ansibot
Copy link
Contributor

ansibot commented Nov 13, 2017

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/plugins/inventory/nmap.py:119:41: too-many-format-args Too many arguments for format string

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 13, 2017
@gundalow gundalow added networking Network category and removed needs_triage Needs a first human triage before being processed. labels Nov 13, 2017
@gundalow gundalow changed the title Nmap inv Nmap inventory Nov 13, 2017
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 13, 2017
@gundalow gundalow mentioned this pull request Nov 22, 2017
Closed
@tyll
Copy link
Contributor

tyll commented Nov 22, 2017

Interesting idea. Did you consider using the nmap XML output? Then you could use an XML parser instead of relying on the human-readable output. nmap -oX - makes nmap output XML on stdout.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 22, 2017
@gundalow
Copy link
Contributor

gundalow commented Dec 6, 2017

@tyll I believe that was considered, though it would add a dependency on an XML library which we don't currently have.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 19, 2017
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 27, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 4, 2018
@bcoca bcoca mentioned this pull request Feb 6, 2018
Open
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 6, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Feb 14, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 22, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@privateip privateip merged commit 5e2f215 into ansible:devel Mar 29, 2018
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@bcoca @ryancurrah
Nmap inventory (ansible#32857)
7d68dda 
* nmap inv plugin draft

* more accurate regex

* fix format
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@bcoca @ilicmilan
Nmap inventory (ansible#32857)
3602625 
* nmap inv plugin draft

* more accurate regex

* fix format
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@privateip privateip Awaiting requested review from privateip

Assignees

@privateip privateip

Labels
affects_2.5 This issue/PR affects Ansible v2.5 feature This issue/PR relates to a feature request. networking Network category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bcoca @ansibot @tyll @gundalow @privateip