Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid AttributeError: internal_network on os_floating_ip #32887

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Avoid AttributeError: internal_network on os_floating_ip #32887

merged 1 commit into from
Nov 14, 2017

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Nov 14, 2017 •
edited
Loading

SUMMARY

Openstack provision fails with AttributeError 'internal_network' error
when required instance is already present in the cloud.

This patch fixes that error by adding additional verification that
the floating ip is on the required nat-destination network.
Fixes #32884

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_floating_ip

ANSIBLE VERSION
2.5.0.0
ADDITIONAL INFORMATION

Needs backporting to 2.4 stable branch too.

@ansibot
Copy link
Contributor

ansibot commented Nov 14, 2017

cc @dagnello @emonty @j2sol @juliakreger @rcarrillocruz @Shrews @Thingee
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. openstack support:community This issue/PR relates to code supported by the Ansible community. labels Nov 14, 2017
@ansibot
Copy link
Contributor

ansibot commented Nov 14, 2017

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/cloud/openstack/os_floating_ip.py:211:43: E126 continuation line over-indented for hanging indent
lib/ansible/modules/cloud/openstack/os_floating_ip.py:212:43: W503 line break before binary operator

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 14, 2017
@ssbarnea
Avoid AttributeError: internal_network on os_floating_ip
b4eaa37 
Fixes ansible#32884

Change-Id: I3be1dc81266b32dd8f545b743365c2bbc02dfdeb
Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 14, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Nov 14, 2017
emonty
emonty approved these changes Nov 14, 2017
View reviewed changes
Copy link
Contributor

@emonty emonty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@Shrews
Copy link
Contributor

Shrews commented Nov 14, 2017

Upon further review of shade, this likely has never worked, so this seems better than not working.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 14, 2017
@ansibot ansibot merged commit 3fedd88 into ansible:devel Nov 14, 2017
abadger pushed a commit that referenced this pull request Nov 14, 2017
@ssbarnea @abadger
Avoid AttributeError: internal_network on os_floating_ip (#32887)
a821a96 
Fixes #32884

Change-Id: I3be1dc81266b32dd8f545b743365c2bbc02dfdeb
Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
(cherry picked from commit 3fedd88)
@abadger
Copy link
Contributor

abadger commented Nov 14, 2017

Cherrypicked to stbale-2.4 for the 2.4.2beta4 release.

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emonty emonty emonty approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. openstack shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

os_floating_ip may throw AttributeError: internal_network
6 participants
@ssbarnea @ansibot @Shrews @abadger @emonty @bcoca