Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nxos_snmp_host bug #32916

Merged
merged 2 commits into from
Nov 16, 2017
Merged

Fix nxos_snmp_host bug #32916

merged 2 commits into from
Nov 16, 2017

Conversation

mikewiebe
Copy link
Contributor

@mikewiebe mikewiebe commented Nov 14, 2017 •
edited
Loading

SUMMARY
  • Fixes a bug in the module due to platform differences
  • Adds integration tests

NOTE: This update is needed in 2.4.2.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_snmp_host

ANSIBLE VERSION
ansible 2.5.0 (rel242/fix_snmp d77364437e) last updated 2017/11/14 17:30:09 (GMT -400)
  config file = None
  configured module search path = [u'/Users/mwiebe/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/mwiebe/Projects/nxos_ansible/fix_ansible/lib/ansible
  executable location = /Users/mwiebe/Projects/nxos_ansible/fix_ansible/bin/ansible
  python version = 2.7.13 (default, Apr  4 2017, 08:47:57) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.38)]

@ansibot
Copy link
Contributor

ansibot commented Nov 14, 2017

cc @GGabriele @jedelman8 @kedarX @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Nov 14, 2017
@ansibot
Copy link
Contributor

ansibot commented Nov 14, 2017

The test ansible-test sanity --test yamllint [?] failed with the following error:

test/integration/targets/nxos_snmp_host/tasks/nxapi.yaml:26:1: too many blank lines (1 > 0) (empty-lines)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 14, 2017
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 14, 2017
@kedarkekan kedarkekan removed the needs_triage Needs a first human triage before being processed. label Nov 15, 2017
@trishnaguha trishnaguha self-assigned this Nov 15, 2017
@trishnaguha trishnaguha added this to Nice to have in 2.4.x Blocker List Nov 15, 2017
@trishnaguha trishnaguha merged commit 208208a into ansible:devel Nov 16, 2017
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Nov 16, 2017
@mikewiebe @trishnaguha
Fix nxos_snmp_host bug (ansible#32916)
e4a9001 
* Fix nxos_snmp_host bug

* Enable nxos_snmp_host tests

(cherry picked from commit 208208a)
trishnaguha added a commit that referenced this pull request Nov 16, 2017
@trishnaguha
Fix nxos_snmp_host bug (#32916) (#32958)
8398de7 
* Fix nxos_snmp_host bug (#32916)

* Fix nxos_snmp_host bug

* Enable nxos_snmp_host tests

(cherry picked from commit 208208a)

* update changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha
Copy link
Member

cherry-picked to 2.4

@trishnaguha trishnaguha moved this from Nice to have to Done in 2.4.2 in 2.4.x Blocker List Nov 16, 2017
@mikewiebe mikewiebe deleted the rel242/fix_snmp branch February 5, 2018 16:09
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikewiebe @ansibot @trishnaguha @dagwieers @kedarkekan