Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan group_vars/host_vars in sorted order #32963

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Scan group_vars/host_vars in sorted order #32963

merged 1 commit into from
Nov 21, 2017

Conversation

NomAnor
Copy link

@NomAnor NomAnor commented Nov 16, 2017

SUMMARY

Fixes #31689

ISSUE TYPE
  • Feature Pull Request
  • Docs Pull Request
COMPONENT NAME

host_group_vars plugin

@ansibot
Copy link
Contributor

ansibot commented Nov 16, 2017

cc @dharmabumstead
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 docs_pull_request needs_triage Needs a first human triage before being processed. plugins/vars support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 16, 2017
@samdoran
Copy link
Contributor

cc @bcoca

@samdoran samdoran added c:vars/hostvars and removed needs_triage Needs a first human triage before being processed. labels Nov 16, 2017
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Nov 16, 2017
@bcoca
Copy link
Member

bcoca commented Nov 16, 2017

I'm ok with adding it, but it should be a toggle as others might be relying on the previous behaviour.

@bcoca bcoca added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Nov 16, 2017
@logan2211
Copy link
Contributor

logan2211 commented Nov 21, 2017 •
edited

Good fix, restores previous vars loading order from <2.4, tested and working for me. Thanks

@bcoca bcoca added this to Blocker in 2.4.x Blocker List Nov 21, 2017
@bcoca bcoca merged commit a9b15ce into ansible:devel Nov 21, 2017
@bcoca bcoca moved this from Blocker to Done in 2.4.2 in 2.4.x Blocker List Nov 21, 2017
@bcoca bcoca moved this from Done in 2.4.2 to Blocker in 2.4.x Blocker List Nov 21, 2017
@bcoca
Copy link
Member

bcoca commented Nov 21, 2017

backported to 2.4.2

@bcoca bcoca moved this from Blocker to Done in 2.4.2 in 2.4.x Blocker List Nov 21, 2017
@ansibot ansibot added docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. and removed docs_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 c:vars/hostvars docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. plugins/vars support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible 2.4 group_vars not parsed lexicographically
5 participants
@NomAnor @ansibot @samdoran @bcoca @logan2211