Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix include in loop when stategy=free #33094

Merged
merged 1 commit into from
Nov 27, 2017
Merged

Fix include in loop when stategy=free #33094

merged 1 commit into from
Nov 27, 2017

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Nov 20, 2017 •
edited
Loading

SUMMARY

Fixes #23216

git bisect'ed to b12256a.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

executor/play_iterator.py

ANSIBLE VERSION
2.3
2.4
devel
ADDITIONAL INFORMATION

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 20, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Nov 20, 2017
@mkrizek mkrizek added this to IN PROGRESS in CEM Nov 21, 2017
@mkrizek mkrizek changed the title [WIP] Fix loop_control in the free stategy Fix include in loop when stategy=free Nov 21, 2017
@mkrizek mkrizek added affects_2.3 This issue/PR affects Ansible v2.3 affects_2.4 This issue/PR affects Ansible v2.4 and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Nov 21, 2017
@ansibot ansibot added the test This PR relates to tests. label Nov 21, 2017
@mkrizek mkrizek requested a review from jimi-c November 21, 2017 13:38
@mkrizek mkrizek mentioned this pull request Nov 21, 2017
Closed
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Nov 21, 2017
@mkrizek mkrizek moved this from IN PROGRESS to READY TO REVIEW in CEM Nov 21, 2017
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Nov 21, 2017
jimi-c
jimi-c approved these changes Nov 27, 2017
View reviewed changes
Copy link
Member

@jimi-c jimi-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jctanner jctanner merged commit 3a2a1e0 into ansible:devel Nov 27, 2017
@mkrizek mkrizek deleted the fix-23216 branch November 27, 2017 16:42
mkrizek added a commit that referenced this pull request Nov 27, 2017
@mkrizek
Fix include in loop when stategy=free (#33094)
131664b 
(cherry picked from commit 3a2a1e0)
@mkrizek mkrizek moved this from READY TO REVIEW to DONE in CEM Nov 27, 2017
@mkrizek mkrizek added this to Next release in 2.4.x Blocker List Nov 28, 2017
abadger pushed a commit that referenced this pull request Dec 6, 2017
@mkrizek @abadger
Fix include in loop when stategy=free (#33094)
ada8453 
(cherry picked from commit 3a2a1e0)
@abadger abadger moved this from Next release to Nice to have in 2.4.x Blocker List Dec 6, 2017
@abadger
Copy link
Contributor

abadger commented Dec 6, 2017

cherry-picked for the 2.4.3beta1 release

@abadger abadger moved this from Nice to have to Done in 2.4.3 in 2.4.x Blocker List Dec 6, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jimi-c jimi-c jimi-c approved these changes

Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 affects_2.4 This issue/PR affects Ansible v2.4 affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. executor/play_iterator support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.3
CEM
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loop_control not work when stategy is free and role have any tasks.
6 participants
@mkrizek @abadger @jimi-c @bcoca @jctanner @ansibot