Add support for user and constraints to pip module #33098
Closed
+106
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.5
|
The test |
ansibot
added
needs_revision
bcoca
removed
the
needs_triage
emonty
force-pushed
the
add-user-and-constraints
branch
from
7cb9fb7
to
b208e64
Compare
|
CI failure in integration tests: |
mattclay
added
the
ci_verified
openstack-gerrit
pushed a commit
to openstack-infra/zuul-jobs
that referenced
this pull request
Nov 21, 2017
Sphinx jobs and reno jobs need basically the same thing for dependencies. So make a new role, ensure-sphinx, which is parameterizable enough that it can be used by both reno and sphinx jobs. Make build jobs for both releasenotes and sphinx docs, as both of these things are perfectly valid things to do in both OpenStack and non-OpenStack contexts. We'll add an openstack specific job in openstack-zuul-jobs that uses these as parents but adds the requirements repo and constraints file settings. Some of the pip commands here can be improved once ansible/ansible#33098 lands and is released, which would allow specifying --user and -c as parameters to the pip module. Change-Id: Idd7caf7d88b56d61872906027b4ce7d743572ded Needed-By: I57de14580f39b9e1c11a587b51b44b61b02c84da
robinro
reviewed
Nov 22, 2017
| # Once it does/can, change this to verify using req_installed.version instead | ||
| # of looking in stdout_lines | ||
| - name: check that version of package was installed that we expect | ||
| assert: |
There was a problem hiding this comment.
This check should be after the register task.
| user: yes | ||
|
|
||
| # TODO pip module does not report back version in the return info. | ||
| # Once it does/can, change this to verify using req_installed.version instead |
There was a problem hiding this comment.
Feel free to implement this :)
It shouldn't be too hard. We already return the version when given as input and the version is available in _is_present.
There was a problem hiding this comment.
Cool - I'll do that in a second PR.
ansibot
added
the
stale_ci
emonty
force-pushed
the
add-user-and-constraints
branch
from
b208e64
to
b6368da
Compare
ansibot
removed
ci_verified
pip supports a --user flag, which tells pip to install to the Python user install directory. Add it as a boolean flag. pip also supports a -c/--constraint option that can be used to supply a file containing constraints to apply to how pip resolves dependencies. Add a parameter allowing a user to provide a path to a constraints file.
emonty
force-pushed
the
add-user-and-constraints
branch
from
b6368da
to
fe0560d
Compare
|
CI failure in integration tests. Most of the errors appear to be: The RHEL 7.4 failure is unrelated to the PR and should be resolved when CI runs again. |
ansibot
added
the
stale_ci
|
@emonty The tests are still not green. Can you have another look? |
ansibot
added
feature
ansibot
added
the
needs_rebase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
pip supports a --user flag, which tells pip to install to the Python
user install directory. Add it as a boolean flag.
pip also supports a -c/--constraint option that can be used to supply a
file containing constraints to apply to how pip resolves dependencies.
Add a parameter allowing a user to provide a path to a constraints file.
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/packaging/language/pip.py
ADDITIONAL INFORMATION
Both of these can be put into extra_args of course, but it doing so in playbooks where they are optional parameters starts to get really awkward, while having them as parameters allows use of things like default(omit)