added flatten filter #33102
Merged
added flatten filter #33102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.5
bcoca
removed
the
needs_triage
ansibot
added
the
stale_ci
ansibot
added
docs_pull_request
and removed
stale_ci
ansibot
added
support:community
ansibot
added
needs_ci
mgedmin
reviewed
Dec 14, 2017
|
|
||
| {{ [3, [4, 2] ]|flatten }} | ||
|
|
||
| Flatten only the first level of a list (aking to the `items` lookup):: |
mgedmin
reviewed
Dec 14, 2017
lib/ansible/plugins/filter/core.py
Outdated
| elif levels is None: | ||
| ret.extend(flatten(element)) | ||
| else: | ||
| break |
There was a problem hiding this comment.
This seems wrong to me.
Consider levels=1. You decrement that to levels=0, then the if levels >= 0: branch gets taken and you recursively call flatten(element, levels=0). Here you find a nested subelement that is a list, so you check if levels: which is False, then you check if levels is None, which is also False, so you break, truncating mylist at the 1st item that happens to be a list.
There was a problem hiding this comment.
hmm, not sure how to check that initial input in levels is non 0
There was a problem hiding this comment.
@mgedmin should be fixed now
ansibot
removed
the
needs_revision
ansibot
added
the
needs_revision
ansibot
added
docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
filter that flattens ... much easier to use than the lookup and has a 'level' interface
ISSUE TYPE
COMPONENT NAME
filters/flatten
ANSIBLE VERSION