Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loopback doesn't support passive_interface #33252

Merged
merged 1 commit into from
Nov 27, 2017
Merged

loopback doesn't support passive_interface #33252

merged 1 commit into from
Nov 27, 2017

Conversation

trishnaguha
Copy link
Member

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

fixes #33245

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/nxos/nxos_interface_ospf

ANSIBLE VERSION
devel

@trishnaguha trishnaguha added networking Network category nxos Cisco NXOS community labels Nov 24, 2017
@trishnaguha trishnaguha added this to Nice to have in 2.4.x Blocker List Nov 24, 2017
@ansibot
Copy link
Contributor

ansibot commented Nov 24, 2017

cc @GGabriele @Qalthos @ganeshrn @gundalow @kedarX @mikewiebe @privateip @rahushen @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request ci_verified Changes made in this PR are causing tests to fail. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Nov 24, 2017
@ansible ansible deleted a comment from ansibot Nov 24, 2017
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 24, 2017
@trishnaguha
loopback doesn't support passive_interface
380fbff 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha merged commit 25a465f into ansible:devel Nov 27, 2017
@trishnaguha trishnaguha deleted the nxos_interface_ospf_fix branch November 27, 2017 17:26
abadger pushed a commit that referenced this pull request Dec 6, 2017
@trishnaguha @abadger
loopback doesn't support passive_interface (#33252)
790e290 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 25a465f)
@abadger
Copy link
Contributor

abadger commented Dec 6, 2017

cherry-picked for the 2.4.3 beta1 release.

@abadger abadger moved this from Nice to have to Done in 2.4.3 in 2.4.x Blocker List Dec 6, 2017
@ansibot ansibot added the bug This issue/PR relates to a bug. label Mar 6, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nxos_interface_ospf : Passive interface is not supported on loopbacks
5 participants
@trishnaguha @ansibot @abadger @Qalthos @dagwieers