Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated pamd rule args regexp to match file paths also #33432

Merged
merged 2 commits into from
Nov 30, 2017
Merged

updated pamd rule args regexp to match file paths also #33432

merged 2 commits into from
Nov 30, 2017

Conversation

rfrancis
Copy link
Contributor

SUMMARY

Changed the rule args regexp to include . and / so it'll catch file paths, e.g. pam_echo.so file=/tmp/blah. @mscherer and @pilou- figured it out, I tested it and checked it in. Includes change to pamd and new unit test check(s) courtesy of @pilou-.

Fixes #33351

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

pamd module

ANSIBLE VERSION
ansible 2.5.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/etc/ansible/library']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible-2.5.0-py2.7.egg/ansible
  executable location = /root/ansible/bin/ansible
  python version = 2.7.5 (default, Aug  4 2017, 00:39:18) [GCC 4.8.5 20150623 (Red Hat 4.8.5-16)]

rfrancis and others added 2 commits November 30, 2017 11:23
@rfrancis
Added . and / to rule args regexp
ef1d283 
Things like pam_echo.so file=/etc/foo.txt weren't being matched and
causing incorrect change counts.  Adding / and . fixed that.

Fixes ansible#33351
@pilou-
pamd: test argument with value
5839504 
Relates ansible#33351
@ansibot
Copy link
Contributor

ansibot commented Nov 30, 2017

cc @kevensen
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Nov 30, 2017
@samdoran samdoran merged commit e957760 into ansible:devel Nov 30, 2017
@samdoran samdoran added this to Next release in 2.4.x Blocker List Nov 30, 2017
samdoran pushed a commit that referenced this pull request Nov 30, 2017
@rfrancis @samdoran
updated pamd rule args regexp to match file paths also (#33432)
f0741ec 
* Added . and / to rule args regexp

Things like pam_echo.so file=/etc/foo.txt weren't being matched and
causing incorrect change counts.  Adding / and . fixed that.

Fixes #33351

(cherry picked from commit e957760)
@samdoran samdoran moved this from Next release to Done in 2.4.1 in 2.4.x Blocker List Nov 30, 2017
@samdoran samdoran removed this from Done in 2.4.1 in 2.4.x Blocker List Nov 30, 2017
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Dec 1, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spurious "changed" value using args_present in pamd module
4 participants
@rfrancis @ansibot @samdoran @pilou-