Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add q/query aliases to lookup #33466

Merged
merged 3 commits into from Dec 14, 2017
Merged

Add q/query aliases to lookup #33466

merged 3 commits into from Dec 14, 2017

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Dec 1, 2017 •
edited

SUMMARY

Also forces wantlist=True when using the alias
Should make using lookups with loop much easier

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

L

ANSIBLE VERSION
2.5

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 feature_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 1, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Dec 1, 2017
@maxamillion
Copy link
Contributor

👍

shipit

@kustodian
Copy link
Contributor

Like the change, I'm just not sure about the name, because L isn't something which will be obvious to the user what it actually does and Ansible is well know for it's readability. And when you think about it it's even harder to search for it on Google, what are you going to type ansible l command?

I'm more for llookup (aka list lookup), but that is also bad.

@maxamillion
Copy link
Contributor

Agreed, llookup is more explicit even though it is more typing.

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 1, 2017
@ansible ansible deleted a comment from ansibot Dec 1, 2017
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 1, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 9, 2017
@bcoca
renamed to q/query as per core meeting
8564384 
also force wantlist=true
@bcoca bcoca changed the title Add L alias to lookup, defaults to real list Add q/query aliases to lookup Dec 14, 2017
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 14, 2017
maxamillion
maxamillion approved these changes Dec 14, 2017
View reviewed changes
Copy link
Contributor

@maxamillion maxamillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on feedback from today's ansible-core IRC meeting about the bikeshedding aspect of the change, the code looks good. 👍

@sivel
Copy link
Member

sivel commented Dec 14, 2017

My personal opinion about wantlist for q|query is that it should be forced as true, and not configurable.

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 14, 2017
@bcoca
Copy link
Member Author

bcoca commented Dec 14, 2017

@sivel check code, already done

@sivel
Copy link
Member

sivel commented Dec 14, 2017

@sivel check code, already done

Awesome, thanks! I must not have refreshed and was looking at an older version. 👍

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 14, 2017
@maxamillion maxamillion merged commit 67c8382 into ansible:devel Dec 14, 2017
@bcoca bcoca deleted the L branch December 19, 2017 20:39
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxamillion maxamillion maxamillion approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bcoca @maxamillion @kustodian @sivel @ansibot