Commits on Dec 6, 2017

1. fixed: win_copy failure from a VirtualBox share to a local path …

   In the case when a source file/folder is on a VirtualBox share then
   win_copy task fails.
   E.g.
     - name: Copy file from VirtualBox share
       win_copy:
         src: \\vboxsvr\share\file
         dest: c:\local\path
         remote_src: true
   
   The reason is that .GetAccessControl method fails somehow for a
   file/folder on a VirtualBox share.
   
     PS c:\Users\vboxuser> $file = Get-Item -Path \\vboxsvr\share\file
     PS c:\Users\vboxuser> $file.GetAccessControl();
     Exception calling "GetAccessControl" with "0" argument(s): "Method
     failed with unexpected error code 1."
     ...
   
   <Jordan Borean (jborean93@gmail.com)> (@jborean93) said (see GitHub PR
   !33576):
   
   > ... we should just get rid of the ACL stuff in win_copy because;
   >
   > - There is a bug right now and it isn't actually working
   > - When copying a file in Windows manually, it does not bring across the
   >   ACL of the source file anyway
   > - We can add in a future option that copies the ACL but we should set a
   >   flag instead to do this
   
   So, remove the ACL stuff
   
   Signed-off-by: Alexey Shumkin <Alex.Crezoff@gmail.com>
   Reviewed-by: <Jordan Borean (jborean93@gmail.com)>

   

   ashumkin committed Dec 6, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 185bdeb
   • Browse repository at this point

   Copy the full SHA

   185bdeb View commit details

   Browse the repository at this point in the history