Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --vault-id support to ansible-pull #33629

Merged
merged 1 commit into from
Dec 6, 2017
Merged

Add --vault-id support to ansible-pull #33629

merged 1 commit into from
Dec 6, 2017

Conversation

andreaso
Copy link
Contributor

@andreaso andreaso commented Dec 6, 2017

SUMMARY

Without this additional code snippet ansible-pull will still accept
the --vault-id option. It just won't pass the option along when
invoking ansible-pull.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-pull

ANSIBLE VERSION
ansible 2.5.0 (devel 425537861a) last updated 2017/12/06 13:57:34 (GMT +200)
  config file = None
  configured module search path = [u'/home/andreas/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/andreas/labs/ansible/devel/lib/ansible
  executable location = /home/andreas/labs/ansible/devel/bin/ansible
  python version = 2.7.14 (default, Sep 23 2017, 22:06:14) [GCC 7.2.0]

@andreaso
Add --vault-id support to ansible-pull
b0df573 
Without this additional code snippet `ansible-pull` will still accept
the `--vault-id` option. It just won't pass the option along when
invoking `ansible-pull`.
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 6, 2017
@andreaso andreaso closed this Dec 6, 2017
@andreaso andreaso reopened this Dec 6, 2017
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 6, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Dec 6, 2017
@bcoca bcoca added this to Nominated in 2.4.x Blocker List Dec 6, 2017
@bcoca bcoca merged commit 7bd54a5 into ansible:devel Dec 6, 2017
@abadger abadger moved this from Nominated to Nice to have in 2.4.x Blocker List Dec 6, 2017
@abadger
Copy link
Contributor

abadger commented Dec 6, 2017

cherry-picked for the 2.4.3beta1 release

@abadger abadger moved this from Nice to have to Done in 2.4.3 in 2.4.x Blocker List Dec 6, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andreaso @abadger @bcoca @ansibot