Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always preserve certain keys #33637

Merged
merged 2 commits into from
Dec 12, 2017
Merged

always preserve certain keys #33637

merged 2 commits into from
Dec 12, 2017

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Dec 6, 2017

SUMMARY

fixes #33433

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

results

ANSIBLE VERSION
2.5

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 6, 2017
@mattclay
Copy link
Member

mattclay commented Dec 6, 2017

CI failure in integration and unit tests. Unit test failure:

>               if preserve in result._results:
E               AttributeError: 'TaskResult' object has no attribute '_results'

lib/ansible/executor/task_result.py:96: AttributeError

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Dec 6, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Dec 6, 2017
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Dec 6, 2017
@bcoca bcoca removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 12, 2017
sivel
sivel approved these changes Dec 12, 2017
View reviewed changes
Copy link
Member

@sivel sivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of x, but this looks good otherwise.

@bcoca bcoca merged commit 8d78a82 into ansible:devel Dec 12, 2017
@bcoca bcoca deleted the preserve_results branch December 12, 2017 18:02
@bcoca bcoca added this to Blocker in 2.4.x Blocker List Dec 12, 2017
bcoca added a commit that referenced this pull request Dec 12, 2017
@bcoca
always preserve certain keys (#33637)
5067a13 
* always preserve certain keys

fixes #33433

* results

(cherry picked from commit 8d78a82)
@bcoca bcoca moved this from Blocker to Done in 2.4.3 in 2.4.x Blocker List Dec 12, 2017
@bcoca
Copy link
Member Author

bcoca commented Dec 12, 2017

backported for 2.4.3

@sivel sivel mentioned this pull request Dec 12, 2017
Merged
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning displayed: Failure using method (v2_runner_retry) in callback plugin
4 participants
@bcoca @mattclay @sivel @ansibot