Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetch when retrieving a file with a multiple of the buffer size #33697

Merged
merged 2 commits into from
Dec 12, 2017
Merged

Fix fetch when retrieving a file with a multiple of the buffer size #33697

merged 2 commits into from
Dec 12, 2017

Conversation

jborean93
Copy link
Contributor

SUMMARY

When fetching a file that is a multiple of the offset the code incorrectly could not handle instances when there was nothing left in the file buffer to copy across.

Fixes #28262

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_fetch

ANSIBLE VERSION
2.5

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 8, 2017
@jborean93 jborean93 added windows Windows community and removed needs_triage Needs a first human triage before being processed. labels Dec 8, 2017
@abadger abadger added this to Blocker in 2.4.x Blocker List Dec 11, 2017
@jborean93 jborean93 merged commit 6e4c690 into ansible:devel Dec 12, 2017
@jborean93 jborean93 deleted the win_fetch-fix branch December 12, 2017 04:56
jborean93 added a commit that referenced this pull request Dec 12, 2017
@jborean93
Fix fetch when retrieving a file with a multiple of the buffer size (#…
39f5905 
…33697)

* Fix fetch when retrieving a file with a multiple of the buffer size

* fixed sanity issue

(cherry picked from commit 6e4c690)
@jborean93
Copy link
Contributor Author

Forgot to say this fix was cherry-picked to stable-2.4 39f5905 and will be available in the 2.4.3 release.

@jborean93 jborean93 moved this from Blocker to Done in 2.4.3 in 2.4.x Blocker List Dec 19, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone Awaiting requested review from nitzmahone

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
No open projects
2.4.x Blocker List
Done in 2.4.3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch module failed to get particular size of file from Windows by WinRM
2 participants
@jborean93 @ansibot