Fixes #33771 - win_iis_webapppool bugfix

[Gianlu]

SUMMARY

Bugfix in win_iis_webapppool module (#33771). The module throws an exception in stopping IIS Web Application Pool. I added a variable that tracks if a change in application pool happened.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

win_iis_webapppool

ANSIBLE VERSION

ansible 2.4.2.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/usr/share/ansible/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.9 (default, Jun 29 2016, 13:08:31) [GCC 4.9.2]

ADDITIONAL INFORMATION

before

fatal: [webserver01]: FAILED! => {"attributes": {}, "changed": true, "info": {"attributes": {}, "cpu": {}, "failure": {}, "name": "apppool", "processModel": {}, "recycling": {"periodicRestart": {}}, "state": "stopped"}, "msg": "Failed to stop Web App Pool apppool: The service cannot accept control messages at this time. (Exception from HRESULT: 0x80070425)"}

after

changed: [webserver01]

[ansibot]

cc @dagwieers @henrikwallstrom @jborean93 @jhawkesworth
click here for bot help

[jborean93]

Looking at the code again, I'm not sure why I kept https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_iis_webapppool.ps1#L258-L268 in the code after the rewrite as the block below it is what should be starting and stopping the web pool. Are you able to update your PR with those lines removed and see if that fixes your issue?

[Gianlu]

Hi,
I checked your suggestion and after removing that lines the module works as expected.
I updated the PR.
Thank you

[jborean93]

Thanks @Gianlu for the fix

[jborean93]

Cherry picked to stable-2.4 07a1217, will be available in the 2.4.3 release.