Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios_config save #33791

Merged
merged 3 commits into from
Dec 13, 2017
Merged

ios_config save #33791

merged 3 commits into from
Dec 13, 2017

Conversation

jmighion
Copy link
Member

SUMMARY

Fixes #32980 by checking save:. Adds new option save_when: changed. Saves the config if a change has been made during the execution of the module, just like aruba_config.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_config

ANSIBLE VERSION
$ ansible --version
ansible 2.5.0 (ios_config_save cdf087f3f5) last updated 2017/12/11 14:17:14 (GMT -700)
  config file = None
  configured module search path = [u'/Users/james/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/james/Documents/git/ansible/lib/ansible
  executable location = /Users/james/Documents/git/ansible/bin/ansible
  python version = 2.7.13 (default, Jul 18 2017, 09:17:00) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)]

@ansibot
Copy link
Contributor

ansibot commented Dec 11, 2017

cc @Qalthos @ganeshrn @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Dec 11, 2017
@gundalow gundalow mentioned this pull request Dec 12, 2017
Closed
gundalow
gundalow requested changes Dec 12, 2017
View reviewed changes
lib/ansible/modules/network/ios/ios_config.py
@@ -181,10 +181,11 @@
will only be copied to the startup-config if it has changed since
the last save to startup-config. If the argument is set to
I(never), the running-config will never be copied to the
startup-config
startup-config. If the argument is set to I(changed), then the running-config
will only be copied to the startup-config if the task has made a change.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please state that I(changed) was added in Ansible 2.5.

@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Dec 12, 2017
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 12, 2017
@gundalow
Copy link
Contributor

Final review needed by @Qalthos or @ganeshrn

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 12, 2017
@calfonso calfonso merged commit 3a9083c into ansible:devel Dec 13, 2017
ganeshrn pushed a commit to ganeshrn/ansible that referenced this pull request Dec 13, 2017
@jmighion @ganeshrn
ios_config save (ansible#33791)
926314e 
* Fixing save so it still works. Adding changed as an option for save_when.

* Updating unit tests.

* Updating description to state that changed was added in 2.5.

(cherry picked from commit 3a9083c)

* Update Changelog
@ganeshrn ganeshrn mentioned this pull request Dec 13, 2017
Merged
ganeshrn added a commit that referenced this pull request Dec 13, 2017
@ganeshrn
ios_config save (#33791) (#33872)
13937ce 
* Fixing save so it still works. Adding changed as an option for save_when.

* Updating unit tests.

* Updating description to state that changed was added in 2.5.

(cherry picked from commit 3a9083c)

* Update Changelog
@ganeshrn
Copy link
Member

Backported to 2.4 #33872

@bdowling
Copy link
Contributor

bdowling commented Dec 13, 2017 •
edited
Loading

Does this PR reverse the deprecation of the 'save' option since it brings it back to life? e.g. should removed_in_version=2.4 be delete from save (and relevant comment in usage help)?

@jmighion
Copy link
Member Author

@bdowling good catch. fixing that in #33885

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Feb 27, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@ganeshrn ganeshrn ganeshrn approved these changes

@Qalthos Qalthos Awaiting requested review from Qalthos

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ios_config 'save' option was removed in 2.4 still has deprecation as only a warning
7 participants
@jmighion @ansibot @gundalow @ganeshrn @bdowling @calfonso @dagwieers