Fix tests as filters #4 #33930
Merged
Fix tests as filters #4 #33930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot, I'll need to add docs for the code smell test |
ansibot
added
affects_2.5
Akasurde
removed
the
needs_triage
sivel
force-pushed
the
fix-tests-as-filters-4
branch
from
dd95835
to
5ff8d00
Compare
ansibot
added
networking
|
shipit |
mattclay
requested changes
Dec 21, 2017
|
|
||
| Jinja tests are used for comparisons, whereas filters are used for data manipulation, and have different applications in jinja. This change is to help differentiate the concepts for a better understanding of jinja, and where each can be appropriately used. | ||
|
|
||
| As of Ansible 2.5 using an Ansible provided jinja test with filter syntax, will display a deprecation error. |
| Sanity Tests » no-tests-as-filters | ||
| ================================== | ||
|
|
||
| Using Ansible provided jinja tests as filters will be removed in Ansible 2.9. |
There was a problem hiding this comment.
Use Jinja2 instead of jinja here and in following sentences.
|
|
||
| FILTER_RE = re.compile(r'((.+?)\s*([\w \.\'"]+)(\s*)\|(\s*)(\w+))') | ||
|
|
||
| all_matches = defaultdict(list) |
There was a problem hiding this comment.
Put the test body in a main function called with the standard if __name__ == '__main__' conditional.
It's not really an issue now, but if we start running import tests on code smell tests we'll want that.
|
|
||
| if all_matches: | ||
| print('Use of Ansible provided Jinja tests as filters is deprecated.') | ||
| print('Please update to use `is` syntax such as `result is failed`') |
There was a problem hiding this comment.
There should probably be at the end of the sentence.
| all_matches[path].append(match[0]) | ||
|
|
||
| if all_matches: | ||
| print('Use of Ansible provided Jinja tests as filters is deprecated.') |
|
@mattclay feedback addressed |
mattclay
requested changes
Dec 21, 2017
|
|
||
| Prior to Ansible 2.5, Jinja2 tests included within Ansible were most often used as filters. The large difference in use is that filters are referenced as ``variable | filter_name`` where as Jinja2 tests are refereced as ``variable is test_name``. | ||
|
|
||
| Jinja tests are used for comparisons, whereas filters are used for data manipulation, and have different applications in Jinja2. This change is to help differentiate the concepts for a better understanding of Jinja2, and where each can be appropriately used. |
There was a problem hiding this comment.
One more Jinja to Jinja2 fix here.
ansibot
added
the
needs_revision
sivel
force-pushed
the
fix-tests-as-filters-4
branch
from
5e65ce3
to
0b8b1ca
Compare
|
@mattclay addressed |
mattclay
approved these changes
Dec 21, 2017
ansibot
removed
the
needs_revision
ansibot
added
docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Address recent changes to tests to fix jinja tests as filters
Following on #32361 this PR fixes tests as filters syntax to use proper is test syntax in newly modified files.
Additionally, the PR adds a code smell test to check for tests as filters syntax.
ISSUE TYPE
COMPONENT NAME
tests
ANSIBLE VERSION
ADDITIONAL INFORMATION