Add the possibility to assign a default value to env lookup #34189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default lookup('env', ) returns an empty string if the variable does not
exists, and force the user to add boolean=True to the default() jinja filter
(see #15575)
This is a proposition to assign a default value to a environment
variable, directly in the lookup plugin, in the same way of os.getenv()
python function.
So:
{{ lookup('env', 'OTHER_HOME')|default('playbook_dir/../other', true) }}
Can be replaced by:
{{ lookup('env', 'OTHER_HOME, playbook_dir/../other') }}
Signed-off-by: Blaisonneau David <david.blaisonneau@orange.com>
ansibot
added
affects_2.5
|
The test |
ansibot
added
the
needs_revision
mkrizek
removed
the
needs_triage
Signed-off-by: Blaisonneau David <david.blaisonneau@orange.com>
ansibot
removed
the
needs_revision
ansibot
added
needs_rebase
|
We have previously decided to not accept this specific change. Using the If you have further questions please stop by IRC or the mailing list:
|
ansibot
added
feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
By default lookup('env', ) returns an empty string if the variable does not
exists, and force the user to add boolean=True to the default() jinja filter
(see #15575)
This is a proposition to assign a default value to a environment
variable, directly in the lookup plugin, in the same way of os.getenv()
python function.
ISSUE TYPE
COMPONENT NAME
plugins/lookup/env
ANSIBLE VERSION
ansible 2.4.2.0
ADDITIONAL INFORMATION
Can now also be written: