Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add documentation around commonly-used Facts for Conditionals #34263

Merged
merged 2 commits into from
Jan 22, 2018
Merged

add documentation around commonly-used Facts for Conditionals #34263

merged 2 commits into from
Jan 22, 2018

Conversation

afeld
Copy link
Contributor

@afeld afeld commented Dec 27, 2017

SUMMARY

There are a few Facts that are often used for Conditionals, so documenting them on the Conditionals page with their possible values. The question originally came up in this mailing list thread.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

System facts

ANSIBLE VERSION
ansible 2.4.2.0
  config file = None
  configured module search path = [u'/Users/aidanfeldman/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/var/pyenv/versions/2.7.14/lib/python2.7/site-packages/ansible
  executable location = /usr/local/var/pyenv/versions/2.7.14/bin/ansible
  python version = 2.7.14 (default, Dec 27 2017, 12:36:43) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]
ADDITIONAL INFORMATION

I'm new to reStructuredText, so let me know if the formatting could have been done better.

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 docs_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 27, 2017
@afeld
add documentation around commonly-used Facts for Conditionals
a570b72 
There are a few Facts that are often used for Conditionals, so
documenting them on the Conditionals page with their possible values.
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 27, 2017
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Jan 3, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 3, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 11, 2018
dharmabumstead
dharmabumstead approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@dharmabumstead dharmabumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with a small edit

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 18, 2018
alikins
alikins approved these changes Jan 22, 2018
View reviewed changes
Copy link
Contributor

@alikins alikins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. In the future we might want to document more of the facts on their own page, but this seems useful now.

@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Jan 22, 2018
@dharmabumstead dharmabumstead merged commit de60328 into ansible:devel Jan 22, 2018
@dharmabumstead
Copy link
Contributor

Thanks @afeld!

Lujeni pushed a commit to Lujeni/ansible that referenced this pull request Feb 1, 2018
@afeld @Lujeni
add documentation around commonly-used Facts for Conditionals (ansibl…
10c1164 
…e#34263)

* add documentation around commonly-used Facts for Conditionals

There are a few Facts that are often used for Conditionals, so
documenting them on the Conditionals page with their possible values.

* Edit
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alikins alikins alikins approved these changes

@dharmabumstead dharmabumstead dharmabumstead approved these changes

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 docs This issue/PR relates to or includes documentation. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@afeld @dharmabumstead @alikins @gundalow @ansibot